Created attachment 155065 [details] Unified diff Upgrade to 3.6.0. This is not the latest available version, but Ganglia requires a great deal of modification and testing with each upgrade, so newer versions will come later after that testing period. Clean up and simplify port Makefile and patches.
This patch is failing to build with pkg-plist issues: http://pd.valinor.palantiri.org/data/latest-per-pkg/ganglia-monitor-core/3.6.0/84amd64-default.log
Files in /var/db/ganglia are supposed to be left alone during deinstall. They contain the history that Ganglia reports, which must be preserved across upgrades. The existing 3.4.0 port also creates them, using the exact same pkg-install script. Is there a prescribed way to get around such build errors in situations like this?
You should handle everything in pkg-plist: @sample etc/gmond.conf.sample @sample etc/gmetad.conf.sample ... @dir(ganglia,ganglia,) /var/db/ganglia/rrds @dir(ganglia,ganglia,) /var/db/ganglia ${STAGEDIR}/var/db/ganglia/rrds should be created from the post-install, if upstream install doesn't create it. It should not be chmod'ded (perms may only be handled in the plist).
Created attachment 155236 [details] Unified diff Thanks. Since this required some major changes, I did some further clean-up and simplification, including eliminating the OPTIONS menu for gmetad. It's on by default anyway and turning it off only eliminates 2 small binaries and 2 man pages, so I can't imagine many people bothering with it. Also added a pkg-message for ganglia noobs. A new diff is attached.
Why haven't you used @sample?
Just an oversight. You want a new diff, or do you just want to add them yourself? Thanks.
I can add them myself. Also pkg-message should probably become just ====================================================================== To enable services, set gmond_enable/gmond_flags and/or gmetad_enable/gmetad_flags in /etc/rc.conf. ======================================================================
Good catch. New users could still use some direction, though. How about this instead: ====================================================================== First-time configuration: Edit %%PREFIX%%/etc/gmond.conf and %%PREFIX%%/etc/gmetad.conf to suit your network. To enable services, set gmond_enable/gmond_flags and/or gmetad_enable/gmetad_flags in /etc/rc.conf. ======================================================================
Yep, that's good. While doing final inspection of the update, I though that it'd be better to leave GMETAD option in. It brings pretty many depends along with rrdtool, and it's not even enabled by default in configure.
OK with me.
Could you redo the patch then please? Since I'm not familiar with this software I may miss something.
Created attachment 155889 [details] Unified diff New diff attached with gmetad option and @sample.
A commit references this bug: Author: amdmi3 Date: Thu Apr 23 14:33:10 UTC 2015 New revision: 384586 URL: https://svnweb.freebsd.org/changeset/ports/384586 Log: - Update to 3.6.0 - Pass maintainership to submitter PR: 199074 Submitted by: jwbacon@tds.net Changes: head/sysutils/ganglia-monitor-core/Makefile head/sysutils/ganglia-monitor-core/distinfo head/sysutils/ganglia-monitor-core/files/patch-gmetad_Makefile.in head/sysutils/ganglia-monitor-core/files/patch-gmetad_conf.c.in head/sysutils/ganglia-monitor-core/files/patch-gmond_modules_conf.d_modpython.conf.in head/sysutils/ganglia-monitor-core/files/patch-gmond_modules_python_Makefile.in head/sysutils/ganglia-monitor-core/files/patch-lib_default__conf.h.in head/sysutils/ganglia-monitor-core/files/patch-libmetrics_freebsd_metrics.c head/sysutils/ganglia-monitor-core/files/pkg-install.in head/sysutils/ganglia-monitor-core/files/pkg-message.in head/sysutils/ganglia-monitor-core/pkg-plist
SUB_LIST seems to be unneeded, but I'll ignore that to not delay this any further.
You're right, SUB_LIST can be removed since the last changes to pkg-message.in. Feel free to do another commit, or I'll include this change in the next maintainer update.