Bug 199123 - [patch] security/py-kerberos to optionally use Kerberos from base, heimdal, or from MIT
Summary: [patch] security/py-kerberos to optionally use Kerberos from base, heimdal, o...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dan Langille
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-04-02 20:48 UTC by Dan Langille
Modified: 2016-11-30 06:48 UTC (History)
7 users (show)

See Also:
roland: maintainer-feedback+


Attachments
patches for compiling against HEIMDAL port / BASE (6.04 KB, patch)
2015-04-02 20:48 UTC, Dan Langille
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Langille freebsd_committer freebsd_triage 2015-04-02 20:48:15 UTC
Created attachment 155130 [details]
patches for compiling against HEIMDAL port / BASE

Most of this work was done by koobs@ with support from zi@ and all credit should go to them.

Add options for using:

* GSSAPI_BASE
* GSSAPI_HEIMDAL
* GSSAPI_MIT
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2015-04-20 11:54:39 UTC
GSSAPI_HEIMDAL_LIB_DEPENDS and GSSAPI_MIT_LIB_DEPENDS can be removed, these are handled by /usr/ports/Mk/Uses/gssapi.mk

Thanks for the example!
Comment 2 roland 2015-06-08 15:09:23 UTC
Patch seems okay. 

Since I don't have a kerberos installation, I can't verify if the patch is correct.

An update to a newer version might be in order.
Kerberos version on pypi is already @ 1.2.2 

Since I'm listed as maintainer, is there any action required from me?
If somebody wants to be a maintainer for this package that's fine too.
Comment 3 Carlo Strub freebsd_committer freebsd_triage 2015-09-15 21:57:34 UTC
Would you take over maintainership Dan?
Comment 4 Dan Langille freebsd_committer freebsd_triage 2015-09-16 14:28:59 UTC
(In reply to Carlo Strub from comment #3)

Sure, I can take maintainership.
Comment 5 Dan Langille freebsd_committer freebsd_triage 2015-09-16 14:29:44 UTC
If all in favor, I'll proceed with a path and upgrade.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-27 13:17:26 UTC
@Roland, can you approve/deny a change of MAINTAINER, and in the case of the latter, provide alternative instructions please
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-27 13:18:32 UTC
Assign to dvl (with accepted maintainer hand up), who may re-assign or not as necessary
Comment 8 roland 2015-10-27 13:57:43 UTC
(In reply to Kubilay Kocak from comment #6)

I approve a change of maintainer.
Comment 9 John W. O'Brien 2015-11-02 01:31:41 UTC
See upstream bug (thanks Dan!): http://trac.calendarserver.org/ticket/906

Although seven months without accepting the patch doesn't exactly inspire confidence.
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-02 02:30:50 UTC
I have a WIP patch for this too btw.

Probably worth revisiting this issue, attachment 155130 [details], my work and regrouping to get this resolved
Comment 11 Dan Langille freebsd_committer freebsd_triage 2015-11-02 14:41:01 UTC
(In reply to roland from comment #8)
I am happy to become maintainer.
Comment 12 Dan Langille freebsd_committer freebsd_triage 2015-11-09 22:05:11 UTC
see https://reviews.freebsd.org/D4115
Comment 13 commit-hook freebsd_committer freebsd_triage 2015-11-17 15:17:52 UTC
A commit references this bug:

Author: dvl
Date: Tue Nov 17 15:17:02 UTC 2015
New revision: 401816
URL: https://svnweb.freebsd.org/changeset/ports/401816

Log:
  Commit message will be:

  Optionally use Kerberos from base, heimdal, or from MIT
  take maintainership
  PR: 199123
  Approved by: mat (mentor)

Changes:
  head/security/py-kerberos/Makefile
  head/security/py-kerberos/files/
  head/security/py-kerberos/files/extra-patch-src_kerberosbasic.h
  head/security/py-kerberos/files/extra-patch-src_kerberosgss.c
  head/security/py-kerberos/files/extra-patch-src_kerberosgss.h
  head/security/py-kerberos/files/extra-patch-src_kerberospw.h
Comment 14 roland 2016-11-29 10:32:49 UTC
(In reply to Dan Langille from comment #11)

Thatnk you for the offer.

If you want to become maintainer, that's awesome.

What are the steps to arrange this?

Futher more this issue can be closed. 
The patch is already committed and with the maintainer to be changed to
Dan I don't think there is much more to discuss.

I think I don't have enough rights to close this issue.
Who can close this issue?
Comment 15 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-30 06:48:46 UTC
Change was committed (see comment 13), closing.

Maintainer change request should occur in a separate issue, or not require one as current maintainer has provided approval in comment 14.