Bug 199191 - [nanobsd] Allow _.disk.image name to be specified
Summary: [nanobsd] Allow _.disk.image name to be specified
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-06 03:32 UTC by ask
Modified: 2019-01-21 10:09 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ask 2015-04-06 03:32:18 UTC 
I build several slightly different images from my nanobsd build; this small patch makes it faster. The change makes a tiny bit more sense with an optional option to create_image to specify a suffix for the log file. I'm not sure if it's worth including though.

--- /usr/gsrc/freebsd/tools/tools/nanobsd/nanobsd.sh	2014-12-14 06:36:35.000000000 +0000
+++ /x/nanobsd/nanobsd.sh	2015-04-05 16:06:22.000000000 +0000
@@ -66,6 +66,7 @@
 
 # The default name for any image we create.
 NANO_IMGNAME="_.disk.full"
+NANO_IMG1NAME="_.disk.image"
 
 # Options to put in make.conf during buildworld only
 CONF_BUILD=' '
@@ -650,8 +654,8 @@
 	fi
 
 	if ${do_copyout_partition} ; then
-		echo "Writing out _.disk.image..."
-		dd conv=sparse if=/dev/${MD}s1 of=${NANO_DISKIMGDIR}/_.disk.image bs=64k
+		echo "Writing out ${NANO_IMG1NAME}_..."
+		dd conv=sparse if=/dev/${MD}s1 of=${NANO_DISKIMGDIR}/${NANO_IMG1NAME} bs=64k
 	fi
 	mdconfig -d -u $MD
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-28 02:00:50 UTC 
A commit references this bug:

Author: imp
Date: Fri Jul 28 02:00:03 UTC 2017
New revision: 321638
URL: https://svnweb.freebsd.org/changeset/base/321638

Log:
  Allow _.disk.image to be specified.

  Submitted by: ask at develooper dot com (reworked to new structure)
  PR: 199191
  Sponsored by: Netflix
  MFC After: 3 days

Changes:
  head/tools/tools/nanobsd/defaults.sh
  head/tools/tools/nanobsd/legacy.sh
Comment 2 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-21 10:09:05 UTC 
There is a commit referencing this PR, but it's still not closed and has been inactive for some time. Closing the PR as fixed but feel free to re-open it if the issue hasn't been completely resolved.

Thanks