Created attachment 155222 [details] emailrelay port files E-MailRelay is a simple SMTP proxy and store-and-forward message transfer agent (MTA). When running as a proxy all e-mail messages can be passed through a user-defined program, such as a spam filter, which can drop, re-address or edit messages as they pass through. When running as a store-and-forward MTA incoming messages are stored in a local spool directory, and then forwarded to the next SMTP server on request. E-MailRelay can also run as a POP3 server. Messages received over SMTP can be automatically dropped into several independent POP3 mailboxes. WWW: http://emailrelay.sourceforge.net
Created attachment 155238 [details] emailrelay port files Fix typo introduced fixing portlint warning.
Created attachment 155345 [details] Updated shar with additional patch
Thanks for your submission Robert. On initial review: * Sort OPTIONS_* entries alphabetically * Use USES=autoreconf instead of USE_AUTOTOOLS * Use <OPTION>_USE=FOO=yes options helper instead of: if ${PORT_OPTIONS:MGUI} if ${PORT_OPTIONS:MOPENSSL} * You can probably use a DISTNAME or DISTFILES override rather than EXTRACT_SUFX * Licenses and README's dont belong in the ports root * LICENSE and LICENSE_FILE are missing While you're making those changes, please also run and include (as attachments) the following QA results: * portlint -AC * poudriere testport (or bulk -t)
(In reply to Kubilay Kocak from comment #3) I've implemented all your changes and I'm working on poudriere. I just have one comment on your suggestion to use DISTNAME/DISTFILES instead of EXTRACT_SUFX. The source archive is called emailrelay-1.9-src.tar.gz and extracts into the emailrelay-1.9 directory. So the default DISTNAME is fine, however when I specify DISTFILES I get the following warnings from portlint -AC: WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them. So portlint tells me to use EXTRACT_SUFX! :-)
Created attachment 155408 [details] Final shar file incorporating all feedback from humans and tools :-)
Created attachment 155409 [details] Output from portlint -AC There is one warning about wrapping installation of doc files with .if ${PORT_OPTIONS:MDOCS}. But the port doesn't do the install, the makefiles in the distfile do it. So I'm not sure what is expected.
Created attachment 155410 [details] poudriere log with the default options selected and built on 10.1 using amd64
Created attachment 155411 [details] poudriere log with no options selected and built on 10.1 using amd64
Created attachment 155412 [details] poudriere log with all options selected and built on 10.1 using amd64
Created attachment 155428 [details] poudriere log with all options selected and built on 9.3 using amd64
It requires few more changes to meet FreeBSD quality standards before it can be committed. I'll handle it from now, no need to upload any further patches or logs.
(In reply to Alexey Dokuchaev from comment #11) Could you let me know what the remaining issues are? That way I won't make the same mistake next time.
Its been 6 weeks, what is happening with this?
It has now been three months. Is there anything more I can do to help get this completed?
A commit references this bug: Author: danfe Date: Thu Jul 23 16:40:48 UTC 2015 New revision: 392741 URL: https://svnweb.freebsd.org/changeset/ports/392741 Log: Add a port of E-MailRelay, a simple SMTP proxy and store-and-forward message transfer agent (MTA). WWW: http://emailrelay.sourceforge.net/ PR: 199192 Submitted by: Robert Nelson Changes: head/mail/Makefile head/mail/emailrelay/ head/mail/emailrelay/Makefile head/mail/emailrelay/distinfo head/mail/emailrelay/files/ head/mail/emailrelay/files/emailrelay.in head/mail/emailrelay/files/patch-etc_Makefile.am head/mail/emailrelay/files/patch-src_gui_Makefile.am head/mail/emailrelay/files/patch-src_gui_installer.cpp head/mail/emailrelay/files/patch-src_main_configuration.cpp head/mail/emailrelay/pkg-descr head/mail/emailrelay/pkg-plist
Port was added as of ports r392741, thanks and sorry for the delay.