Created attachment 155271 [details] graphics_delaboratory.diff
Can you elaborate on why USES=compiler:c++11-lib is needed now? When I created the port, it was buildable with default system compiler across all versions of FreeBSD.
wxgtk30 currently depends on webkit-gtk2. Any ports using wxgtk30 appears to require C++11 compiler since webkit-gtk2 is built with C++11 compiler. If system compiler does not support C++11, existing delaboratory port fails to build on official package builder because of webkit-gtk2. http://lists.freebsd.org/pipermail/freebsd-pkg-fallout/Week-of-Mon-20150406/227682.html
Created attachment 156709 [details] graphics_delaboratory.diff Chase r383842
> +MAKE_ENV= OPTFLAGS="${CPPFLAGS}" WXCONFIG="${WX_CONFIG}" > +CPPFLAGS+= -I${LOCALBASE}/include > +LDFLAGS+= -L${LOCALBASE}/lib These changes are unexplained and seemingly not needed (ditto for ugly `post-patch' target later in the patch). > +DESKTOP_ENTRIES="Delaboratory" "" \ > + "Color correction utility for digital images" "${PORTNAME}" \ > + "Graphics;Photography;" true I'm not sure that this is both correct (e.g, third argument should be icon name, not "Color correction utility for digital images") and actually needed. This program entirely consists of a single executable (no icon; and does it really need startup notification?), targeted for people who know how to run and use it. That said, unless you can back up proposed (and corrected) changes with sufficient and sound reasoning, I don't see a need for commit.
Created attachment 165553 [details] graphics_delaboratory.diff Chase r405891
Maintainer feedback?
(In reply to tkato432 from comment #5) > Created attachment 165553 [details] > graphics_delaboratory.diff > > Chase r405891 @tkato432 Thanks for stepping up on this while I was away. The patch tests fine for me on @12-CURRENT/64 But I have a question regarding the DESKTOP_ENTRIES addition; given the port *itself* doesn't provide an Icon. How is this resolved? Other than that, I'm fine with the approving the attachment. Thanks again! --Chris
I'm closing this after many years/months of no submitter feedback regarding the concerns raised in comment #4 and again in comment #6. Many of the changes remain unexplained and DESKTOP_ENTRIES is still wrong and out of order.