Bug 199257 - security/whatweb not work
Summary: security/whatweb not work
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-07 05:27 UTC by agr
Modified: 2015-05-06 08:22 UTC (History)
2 users (show)

See Also:

Attachments
Patch to just to runtime issues with Ruby 2.1 (2.09 KB, patch)
2015-05-05 01:28 UTC, Jason Unovitch 		no flags Details | Diff
Patch to update to latest version and modernize port (7.83 KB, patch)
2015-05-05 02:04 UTC, Jason Unovitch 		no flags Details | Diff
Poudriere testport build logs from 10.1-RELEASE amd64 (14.70 KB, text/x-log)
2015-05-05 02:05 UTC, Jason Unovitch 		no flags Details
Patch to update to latest version and modernize port (8.01 KB, patch)
2015-05-05 02:38 UTC, Jason Unovitch 		no flags Details | Diff
Poudriere testport build logs from 10.1-RELEASE amd64 (14.98 KB, text/x-log)
2015-05-05 02:41 UTC, Jason Unovitch 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description agr 2015-04-07 05:27:52 UTC 
port /usr/ports/security/whatweb


>whatweb 81.12.18.19

/usr/local/lib/ruby/site_ruby/2.1/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- md5 (LoadError)
        from /usr/local/lib/ruby/site_ruby/2.1/rubygems/core_ext/kernel_require.rb:54:in `require'
        from /usr/local/bin/whatweb:55:in `<main>'
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 01:28:43 UTC 
Created attachment 156354 [details]
Patch to just to runtime issues with Ruby 2.1
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 01:41:03 UTC 
For submitter,
To fix this runtime issue with Ruby 2.1, there are two lines of code that must change.  See the project's github link:

https://github.com/urbanadventurer/WhatWeb/commit/0f8772651a60f1d80b94cd94cc72c751f7cfdaf3

For maintainer,
For now, patch attached to just add the fix for the runtime issue.

Jason
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 02:04:38 UTC 
Created attachment 156357 [details]
Patch to update to latest version and modernize port

Changes:
 - Update to 7d0256b from upstream git to resolve runtime issues with Ruby 2.1
 - Remove deprecated GH_COMMIT and use just GH_TAGNAME
 - Set NO_ARCH=yes
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 02:05:16 UTC 
Created attachment 156358 [details]
Poudriere testport build logs from 10.1-RELEASE amd64
Comment 5 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 02:09:57 UTC 
For rm@ (added to CC),
Patch attached to just fix the issue.  However, the second patch may be preferred as that fixes the issue by updating to the latest from upstream git.  That follows the precedence set a while back for compatibility with newer Ruby.  The port was also modernized as well per Poudriere testport warnings and is now Poudriere warnings clean.

Jason
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 02:38:50 UTC 
Created attachment 156360 [details]
Patch to update to latest version and modernize port

Changes:
 - Update to 7d0256b from upstream git to resolve runtime issues with Ruby 2.1
 - Remove deprecated GH_COMMIT and use just GH_TAGNAME
 - Set NO_ARCH=yes
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2015-05-05 02:41:43 UTC 
Created attachment 156361 [details]
Poudriere testport build logs from 10.1-RELEASE amd64

Missed GH_COMMIT in DISTVERSION on first patch.  Fixed and updated patch and testport log.
Comment 8 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-05-05 08:29:48 UTC 
My port
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-05-05 16:14:22 UTC 
A commit references this bug:

Author: rm
Date: Tue May  5 16:14:05 UTC 2015
New revision: 385477
URL: https://svnweb.freebsd.org/changeset/ports/385477

Log:
  security/whatweb: update to latest github revision

  - update to latest github revision unbreaking runtime with ruby21
  - adopt github infrastructure changes
  - add LICENSE_FILE
  - PORTREVISION bump was added to leverage versioning scheme change

  PR:		199257
  Submitted by:	 jason.unovitch@gmail.com

Changes:
  head/security/whatweb/Makefile
  head/security/whatweb/distinfo
  head/security/whatweb/pkg-plist
Comment 10 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-05-05 16:16:58 UTC 
Committed, thank you!
Comment 11 Jason Unovitch freebsd_committer freebsd_triage 2015-05-06 00:49:32 UTC 
rm@,
Thanks for the quick fix.  Grabbed it from the freebsd-ports-bugs pool and was about 80% done before looking at the maintainer and realizing what happened.

For original submitter,
Use something like 'security/whatweb' at the start of the PR and it will get routed to the right person when you open it.  Should be quicker that way.  Hope this resolves all the issues you had.

Jason
Comment 12 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2015-05-06 08:22:19 UTC 
Yes, that was the reason why I didn't saw that PR in first place.