Bug 199299 - [maintainer-update] x11-fm/worker: new options for the port, Makefile cleanup
Summary: [maintainer-update] x11-fm/worker: new options for the port, Makefile cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-08 17:03 UTC by mp39590
Modified: 2015-04-13 17:30 UTC (History)
1 user (show)

See Also:


Attachments
patch (1.25 KB, patch)
2015-04-08 17:03 UTC, mp39590
no flags Details | Diff
poudriere build logs (771.46 KB, text/plain)
2015-04-08 17:04 UTC, mp39590
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description mp39590 2015-04-08 17:03:09 UTC
Created attachment 155343 [details]
patch

- add several new options for the port
- default options are now avfs and inotify (former is for accessing an archives, later is for monitoring current directory for changes with kevent() through inotify() shim layer)
- use compiler:c++11-lib instead of checking OSVERSION
- bump PORTVERSION
Comment 1 mp39590 2015-04-08 17:04:05 UTC
Created attachment 155344 [details]
poudriere build logs

build logs for 10.1/9.3/8.4 with all options enabled
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-04-13 10:25:06 UTC
A commit references this bug:

Author: danfe
Date: Mon Apr 13 10:24:14 UTC 2015
New revision: 383906
URL: https://svnweb.freebsd.org/changeset/ports/383906

Log:
  - Sadly, this port requires c++11-capable compiler and library
  - Add missing USES=pkgconfig, or things would be breaking in weird ways
  - Because of the above, we have a chance to properly indent USES
  - Do not assign initial RUN_DEPENDS with +=, it is confusing
  - Add new options (HAL, INOTIFY, LUA); enable AVFS and INOTIFY by default
  - Enable Xinerama support unconditionally because configure script tries
    to detect it, but does not allow to disable (initially was an OPTION)
  - Improve on COMMENT and port description text while I'm here

  PR:		199299
  Submitted by:	maintainer

Changes:
  head/x11-fm/worker/Makefile
  head/x11-fm/worker/pkg-descr
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-13 10:28:22 UTC
Committed with modifications and improvements as ports r383906, thank you.

XINERAMA support is not disable-able (but configure script detects it), and is actually makes little to no sense to make it an OPTION (not a heavy dependency or something, just a part of X.org everyone probably has installed already), so simply add it to USE_XORG.

Do you think it is better to enable XFT support by default?  X11 fonts can cause problems with displaying UTF-8 national strings (outside ASCII range).
Comment 4 mp39590 2015-04-13 17:00:58 UTC
(In reply to Alexey Dokuchaev from comment #3)

> Do you think it is better to enable XFT support by default? 

I've no objections.
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-13 17:08:07 UTC
(In reply to mp39590 from comment #4)
> I've no objections.

Noted; I'll test it again (as I did observe mangled Russian characters without it) and if it improves user experience, I'll enable it by default.
Comment 6 mp39590 2015-04-13 17:09:55 UTC
(In reply to Alexey Dokuchaev from comment #5)

I use russian characters as well and it works for me without XFT.

LC_ALL=en_US.UTF-8
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2015-04-13 17:21:24 UTC
(In reply to mp39590 from comment #6)
> I use russian characters as well and it works for me without XFT.
> LC_ALL=en_US.UTF-8

Quite possible; perhaps I simply do not have Russian glyphs for the font that is being picked up in X11 case.  So it needs investigation, not a prompt, blunt action. :)
Comment 8 mp39590 2015-04-13 17:30:20 UTC
Investigation was rather short.

Starting worker with clear config (worker -c /tmp/foo) shows that "default" font really don't show russian chars properly, but if you go to the settings and select "fixed" instead of "default" - everything is fine, even w/o XFT.

Since I use it for long time it was in my config already.