Bug 199406 - Adjust UNIQUENAME to also include PKGNAMESUFFIX
Summary: Adjust UNIQUENAME to also include PKGNAMESUFFIX
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords:
: 183372 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-13 00:36 UTC by Gerald Pfeifer
Modified: 2016-02-08 04:49 UTC (History)
4 users (show)

See Also:

Attachments
Proposed patch (354 bytes, patch)
2015-04-13 00:36 UTC, Gerald Pfeifer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2015-04-13 00:36:31 UTC 
Created attachment 155529 [details]
Proposed patch

This is related to a discussion we had after I converted the lang/gcc*
ports to use a PORTNAME of just "gcc" and have PKGNAMESUFFIX indicate
the specific version.

That worked just fine -- except it broke the logic around USE_LDCONFIG
which relies on UNIQUENAME, where it turned out those names really were
not unique any more after my "simplifications".

Right now UNIQUENAME does include PKGNAMEPREFIX, but not PKGNAMESUFFIX.

On the mailing lists there was consensus to change that, and I am attaching
the straightforward patch to do so.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2015-04-13 09:14:46 UTC 
This would need a few additions, a UNIQUENAME_OLD that's what it was if different, and some compat shims to move/copy the options in UNIQUENAME_OLD to UNIQUENAME so that people don't loose their options.
Comment 2 David Naylor freebsd_committer freebsd_triage 2015-04-19 13:27:16 UTC 
*** Bug 183372 has been marked as a duplicate of this bug. ***
Comment 3 David Naylor freebsd_committer freebsd_triage 2016-02-08 04:49:19 UTC 
UNIQUENAME has been depreciated.