Bug 199417 - ports-mgmt/portlint: A few changes
Summary: ports-mgmt/portlint: A few changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 14:54 UTC by Mathieu Arnold
Modified: 2015-05-17 22:44 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2015-04-13 14:54:26 UTC
1) if you install to ${DOCSDIR} without .if ${PORT_OPTIONS:MDOCS} it tells you it is bad.  It is not, it is the right way to do it, it should in fact tell you the reverse, something along the lines of "you should only use the .if if the installed tree is *large* and it takes time to copy the files"

2) check that people don't try to use ${ENV} when there in fact mean ${SETENV}, ${ENV} is sometime set to some strange value in sh and it fails with a strange error.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2015-04-15 13:26:27 UTC
About LICENSEs, portlint should give a warning if LICENSE_FILE is not defined when LICENSE is (LICENSE_FILE_xxx if more than one license)
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-05-11 15:38:41 UTC
For the first one, does http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1.358&r2=1.359&f=h do it for you?
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2015-05-11 18:36:32 UTC
(In reply to Joe Marcus Clarke from comment #2)
> For the first one, does
> http://www.marcuscom.com/cgi-bin/cvsweb.cgi/portlint/portlint.pl.diff?r1=1.
> 358&r2=1.359&f=h do it for you?

Looks what I had in mind, yes, thanks.
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2015-05-17 22:44:37 UTC
Changes committed.