Bug 199467 - x11-themes/lxappearance: Build fails with NLS=off
Summary: x11-themes/lxappearance: Build fails with NLS=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-15 17:18 UTC by Tobias Kortkamp
Modified: 2015-04-25 18:29 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (pawel)

Attachments
lxappearance-0.6.1.log (21.89 KB, text/plain)
2015-04-15 17:18 UTC, Tobias Kortkamp 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2015-04-15 17:18:22 UTC 
Created attachment 155626 [details]
lxappearance-0.6.1.log

When unsetting the NLS option for x11-themes/lxappearance the build fails in the configure phase and complains that the gettext tools cannot be found. I have attached the poudriere log.
Comment 1 Beeblebrox 2015-04-25 03:52:27 UTC 
Here's the correct patch, courtesy of Tijl Coosemans.
Tested in poudriere_11-current_amd64.

-------------------------
security/gnomint/Makefile
@@ -16 +16 @@
-USES=		gmake pathfix pkgconfig tar:xz
+USES=		gettext-tools gmake pathfix pkgconfig tar:xz

@@ -28 +28 @@
-NLS_USES=		gettext
+NLS_USES=		gettext-runtime
Comment 2 Beeblebrox 2015-04-25 04:08:16 UTC 
I made a mistake with the filename. Obviously,

x11-themes/lxappearance/Makefile
@@ -16 +16 @@
-USES=		gmake desktop-file-utils libtool pkgconfig tar:xz
+USES=		gettext-tools gmake desktop-file-utils libtool pkgconfig tar:xz

@@ -53 +53 @@
-NLS_USES=		gettext
+NLS_USES=		gettext-runtime
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-04-25 18:29:44 UTC 
A commit references this bug:

Author: pawel
Date: Sat Apr 25 18:28:51 UTC 2015
New revision: 384748
URL: https://svnweb.freebsd.org/changeset/ports/384748

Log:
  - Fix build when NLS=off [1]
  - Use LDFLAGS for linker flags

  PR:		199467 [1]
  Reported by:	tobias.kortkamp@gmail.com [1]

Changes:
  head/x11-themes/lxappearance/Makefile