Bug 199526 - Mk/bsd.ports.mk: Abstract ${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX}
Summary: Mk/bsd.ports.mk: Abstract ${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX}
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-18 22:01 UTC by Gerald Pfeifer
Modified: 2015-04-19 18:35 UTC (History)
1 user (show)

See Also:
bdrewery: maintainer-feedback+

Attachments
Proposed patch (1.66 KB, patch)
2015-04-18 22:01 UTC, Gerald Pfeifer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2015-04-18 22:01:15 UTC 
Created attachment 155707 [details]
Proposed patch

Currently Mk/bsd.ports.mk features five instances of hard-coded
${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX}.

This patch replaces this by a new ${WRKDIR_PKGFILE}.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2015-04-18 23:55:44 UTC 
Please commit
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-04-19 18:33:55 UTC 
A commit references this bug:

Author: gerald
Date: Sun Apr 19 18:33:37 UTC 2015
New revision: 384312
URL: https://svnweb.freebsd.org/changeset/ports/384312

Log:
  Abstract ${WRKDIR}/pkg/${PKGNAME}${PKG_SUFX} which appears five times
  and introduce and use WRKDIR_PKGFILE instead.

  PR:		199526
  Approved by:	portmgr (bdrewery)

Changes:
  head/Mk/bsd.port.mk
Comment 3 Gerald Pfeifer freebsd_committer freebsd_triage 2015-04-19 18:35:54 UTC 
Thanks for the quick review, Bryan.  I waited until I could be online
for several hours directly after the commit (just in case) and went
ahead now.