Bug 199648 - vt(4) mouse cursor becomes "stripey" in the rightmost character column
Summary: vt(4) mouse cursor becomes "stripey" in the rightmost character column
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords: vt
Depends on:
Blocks:
 
Reported: 2015-04-23 17:07 UTC by Ed Maste
Modified: 2015-05-12 18:10 UTC (History)
0 users

See Also:


Attachments
Crop from QEMU screenshot of stripey mouse (153 bytes, image/png)
2015-04-23 17:07 UTC, Ed Maste
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2015-04-23 17:07:12 UTC
Created attachment 155919 [details]
Crop from QEMU screenshot of stripey mouse

See attached crop r281777, QEMU screengrab. Also reproduced on a Thinkpad X220 with i950kms and a little older kernel.
Comment 1 Ed Maste freebsd_committer freebsd_triage 2015-04-24 14:25:32 UTC
Fix in review at https://reviews.freebsd.org/D2360

(VGA will require a similar fix.)
Comment 2 Ed Maste freebsd_committer freebsd_triage 2015-04-24 17:29:48 UTC
I just discovered that this does not happen on stable/10. The latent bug here was exposed by r278673, which expanded the mouse pointer beyond 8 pixels wide.

(https://reviews.freebsd.org/D1801)
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-04-29 20:30:57 UTC
A commit references this bug:

Author: emaste
Date: Wed Apr 29 20:30:11 UTC 2015
New revision: 282247
URL: https://svnweb.freebsd.org/changeset/base/282247

Log:
  vt: fix vt_fb_bitblt_bitmap mask corruption

  Previously the mask wrapped when one or more of the mask bytes extended
  past the right edge of the window. Simplify the logic and use the same
  byte offset and bit in both the pattern and mask.

  PR:		199648
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D2360

Changes:
  head/sys/dev/vt/hw/fb/vt_fb.c
Comment 4 Ed Maste freebsd_committer freebsd_triage 2015-05-06 01:44:38 UTC
Other vt drivers likely require a similar change, and then all should be MFC'd to stable/10.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-05-12 18:08:49 UTC
A commit references this bug:

Author: emaste
Date: Tue May 12 18:08:08 UTC 2015
New revision: 282822
URL: https://svnweb.freebsd.org/changeset/base/282822

Log:
  MFC r282247: vt: fix vt_fb_bitblt_bitmap mask corruption

    Previously the mask wrapped when one or more of the mask bytes extended
    past the right edge of the window. Simplify the logic and use the same
    byte offset and bit in both the pattern and mask.

  PR:		199648
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/10/
  stable/10/sys/dev/vt/hw/fb/vt_fb.c