Bug 199721 - wpa_supplicant - CVE-2015-1863 patch for disabled by default P2P option
Summary: wpa_supplicant - CVE-2015-1863 patch for disabled by default P2P option
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-26 20:07 UTC by Jason Unovitch
Modified: 2015-07-14 03:02 UTC (History)
2 users (show)

See Also:


Attachments
11-CURRENT patch (518 bytes, patch)
2015-04-26 20:07 UTC, Jason Unovitch
no flags Details | Diff
10-STABLE patch (518 bytes, patch)
2015-04-26 20:07 UTC, Jason Unovitch
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Unovitch freebsd_committer freebsd_triage 2015-04-26 20:07:10 UTC
Created attachment 156021 [details]
11-CURRENT patch

Apply patch to base for wpa_supplicant P2P SSID processing vulnerability [1][2]. Ports has already been fixed [3]. The CONFIG_P2P option is disabled by default however fix the code anyway so it doesn't get accidentally enabled.  This follows DragonFly BSD in applying it even though P2P is off by default [4].

Noticed by: Kevin McAleavey in the FreeBSD Forums [5]

Other comments:
- 9.X and 8.X use wpa_supplicant versions earlier than the affected 1.0-2.4 from the advisory.
- 10.1-STABLE uses wpa_supplicant 2.0 and should be patched.
- 11.0-CURRENT uses wpa_supplicant 2.4 and should be patched.


References:
[1] Upstream Advisory:
http://w1.fi/security/2015-1/wpa_supplicant-p2p-ssid-overflow.txt

[2] Upstream Patch:
http://w1.fi/security/2015-1/0001-P2P-Validate-SSID-element-length-before-copying-it-C.patch

[3] Ports PR for security/wpa_supplicant (already fixed):
https://bugs.freebsd.org/199678

[4] Follow DragonFly BSD in applying the same patch:
http://gitweb.dragonflybsd.org/dragonfly.git/commit/584c4a9f0c9071cb62abe9c870a2b08afe746a88

[5] Forum Post
https://forums.freebsd.org/threads/patch-for-wpa_supplicant.51368/
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-04-26 20:07:35 UTC
Created attachment 156022 [details]
10-STABLE patch
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-07-13 01:31:49 UTC
rpaulo@, based off https://reviews.freebsd.org/D2436 it looks the direction here is to not applying patches from upstream since it's not enabled/compiled.

Can you confirm that and I'll close the PR?  Or go ahead and close as not a bug if you choose.
Comment 4 Rui Paulo freebsd_committer freebsd_triage 2015-07-13 15:32:50 UTC
Yes, I think we can close this bug.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2015-07-14 03:02:04 UTC
Submitter agrees that this can be closed.