Bug 199730 - [PATCH] textproc/rubygem-gitlab-linguist update to 3.0.1
Summary: [PATCH] textproc/rubygem-gitlab-linguist update to 3.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Michael Moll
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-04-27 11:40 UTC by Torsten Zühlsdorff
Modified: 2015-05-26 18:34 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ruby)


Attachments
patch against textproc/rubygem-gitlab-linguist (1.36 KB, patch)
2015-04-27 11:40 UTC, Torsten Zühlsdorff
no flags Details | Diff
now with patch of the gemspec (4.22 KB, patch)
2015-05-26 15:08 UTC, Torsten Zühlsdorff
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-04-27 11:40:47 UTC
Created attachment 156037 [details]
patch against textproc/rubygem-gitlab-linguist

While working at a port for gitlab, i figured out, that an update for this gem is needed. Patch attached :)
Comment 1 Torsten Zühlsdorff 2015-04-27 11:41:47 UTC
Poudriere-Testlog:
http://ports.toco-domains.de/poudriere-test-logs/rubygem-gitlab-linguist-3.0.1.log
Comment 2 Michael Moll freebsd_committer freebsd_triage 2015-05-05 21:51:50 UTC
that's not working out of the box:

irb(main):002:0> require 'linguist'
Gem::LoadError: Could not find 'charlock_holmes' (~> 0.6.6) - did find: [charlock_holmes-0.7.3]

at least the gemspec needs to get patched and evaluated if linguist is indeed working with the newer versions of the dependent gem(s).
Comment 3 Torsten Zühlsdorff 2015-05-26 12:50:26 UTC
I will have a look at it. The gemspec at the homepage allows the new charlock_holmes:
https://github.com/github/linguist

But the linked Homepage and the gem itself do not seem to be identical.
Comment 4 Michael Moll freebsd_committer freebsd_triage 2015-05-26 14:03:46 UTC
gitlab-linguist is a fork of github-linguist and the gemspec was not correctly updated, at least not in the last released/tagged version.
Comment 5 Torsten Zühlsdorff 2015-05-26 15:08:21 UTC
Created attachment 157161 [details]
now with patch of the gemspec

I see what you mean. The problem is, that the github version is actually at 4.5.5 while the gem stays at 3.0.1.

I've updated the patch and patches the gemspec. But its not a final patch. More work is needed, but at the moment i could not proceed, because rubygem-rugged is not building. I will have at this later.
Comment 6 Michael Moll freebsd_committer freebsd_triage 2015-05-26 17:54:06 UTC
this is fine, as you can control this via the version pnning in the gemfile then
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-05-26 17:56:31 UTC
A commit references this bug:

Author: mmoll
Date: Tue May 26 17:56:10 UTC 2015
New revision: 387498
URL: https://svnweb.freebsd.org/changeset/ports/387498

Log:
  textproc/rubygem-gitlab-linguist: update to 3.0.1

  PR:		199730
  Differential Revision:	https://reviews.freebsd.org/D2627
  Submitted by:	Torsten Zuehlsdorff <ports@toco-domains.de>
  Approved by:	swills (mentor)

Changes:
  head/textproc/rubygem-gitlab-linguist/Makefile
  head/textproc/rubygem-gitlab-linguist/distinfo
  head/textproc/rubygem-gitlab-linguist/files/
  head/textproc/rubygem-gitlab-linguist/files/patch-gitlab-linguist.gemspec
Comment 8 Michael Moll freebsd_committer freebsd_triage 2015-05-26 18:34:44 UTC
committed, thanks!