Bug 199758 - www/nginx Digest Authentication fails on URLs with a querystring
Summary: www/nginx Digest Authentication fails on URLs with a querystring
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sergey A. Osokin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-28 12:51 UTC by Christos Chatzaras
Modified: 2015-06-13 17:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (osa)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christos Chatzaras 2015-04-28 12:51:04 UTC 
There is a problem with Nginx digest auth module which is described here:

https://github.com/samizdatco/nginx-http-auth-digest/issues/18

The patch is here:

https://github.com/yanchenko-igor/nginx-http-auth-digest/blob/69fcbcb3ff345093f06b066efe18efad3dd84460/ngx_http_auth_digest_module.c

Can you please add this patch to the freebsd port so we don't have to add it manually in every nginx upgrade?
Comment 1 Sergey A. Osokin freebsd_committer freebsd_triage 2015-04-29 22:27:20 UTC 
Hi Christos,

thanks for report.

Unfortunately, I haven't found any patch yet.  Could you please add it to this bug report?

Thanks again.
Comment 2 Christos Chatzaras 2015-05-07 21:25:18 UTC 
Sorry for the delay in my reply. I was too busy the last days.

The original file that is downloaded when we complile nginx digest authentication module is here:

https://github.com/samizdatco/nginx-http-auth-digest/blob/master/ngx_http_auth_digest_module.c

The new file that fix this issue is here:

https://github.com/yanchenko-igor/nginx-http-auth-digest/blob/69fcbcb3ff345093f06b066efe18efad3dd84460/ngx_http_auth_digest_module.c


Here is the patch:

http://pastebin.com/raw.php?i=tQQQ3xAw
Comment 3 Christos Chatzaras 2015-05-15 16:53:03 UTC 
Any update on this?
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2015-05-17 18:07:53 UTC 
Chris,

could you please add the patch to this problem report.

Thanks.
Comment 5 Sergey A. Osokin freebsd_committer freebsd_triage 2015-06-13 17:35:09 UTC 
Committed with modification, thanks for report!
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-13 17:35:24 UTC 
A commit references this bug:

Author: osa
Date: Sat Jun 13 17:34:35 UTC 2015
New revision: 389474
URL: https://svnweb.freebsd.org/changeset/ports/389474

Log:
  Fix digest authentication fail on URLs with a querystring for third-party http_auth_digest module.

  PR:	199758

Changes:
  head/www/nginx/Makefile
  head/www/nginx/files/extra-patch-ngx_http_auth_digest_module.c
  head/www/nginx-devel/Makefile
  head/www/nginx-devel/files/extra-patch-ngx_http_auth_digest_module.c