Bug 200068 - release/scripts/mk-vmimage.sh producing incorrect vmdk format vm-images
Summary: release/scripts/mk-vmimage.sh producing incorrect vmdk format vm-images
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Many People
Assignee: FreeBSD Release Engineering
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-09 10:24 UTC by Jeremy Norris
Modified: 2015-05-14 04:22 UTC (History)
0 users

See Also:


Attachments
Possible fix to mkimg invocation (849 bytes, patch)
2015-05-09 10:24 UTC, Jeremy Norris
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Norris 2015-05-09 10:24:52 UTC
Created attachment 156554 [details]
Possible fix to mkimg invocation

amd64 vmdk images for 10.1-STABLE and 11.0-CURRENT as found on ftp.freebsd.org are not actually vmdk format files, but instead appear to be miscreated raw image files.

Examining release/tools/vmimage.subr for both -head and -stable svn branches, it appears that the mkimg invocation lost the passing of the -f argument during a rewrite a few months ago.

Probably need to change all the mkimg invocations in vmimage.subr to include a "-f ${VMFORMAT}" argument (see attached for possible fix).
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-05-11 14:53:45 UTC
A commit references this bug:

Author: gjb
Date: Mon May 11 14:53:08 UTC 2015
New revision: 282772
URL: https://svnweb.freebsd.org/changeset/base/282772

Log:
  Fix virtual machine disk format creating by passing VMFORMAT
  to mkimg(1)

  PR:		200068
  Submitted by:	Jeremy Norris
  MFC after:	3 days
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/release/tools/vmimage.subr
Comment 2 Glen Barber freebsd_committer freebsd_triage 2015-05-11 14:54:00 UTC
Fixed in r282772.

Thank you for the submission and the fix.
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-05-14 04:21:47 UTC
A commit references this bug:

Author: gjb
Date: Thu May 14 04:21:05 UTC 2015
New revision: 282877
URL: https://svnweb.freebsd.org/changeset/base/282877

Log:
  MFC r282772:
    Fix virtual machine disk format creating by passing VMFORMAT
    to mkimg(1)

  PR:		200068
  Sponsored by:	The FreeBSD Foundation

Changes:
  stable/10/release/tools/vmimage.subr