Created attachment 156556 [details] patch - update www/squid to latest version; - fix GASSAPI_NONE handling; - unbreak eCAP option, but only for FreeBSD < 10, no luck with clang.
Created attachment 156557 [details] poudriere log
Sholdn't > ${OSVERSION} > 1000000 be > ${OSVERSION} >= 1000000 ?
Also, did you report this clang issue to squid bugzilla?
Instead of > BROKEN= Squid with eCAP enabled can't be compiled by clang you could say > USE_GCC=yes ?
(In reply to yuri from comment #2) > Sholdn't >> ${OSVERSION} > 1000000 > be >> ${OSVERSION} >= 1000000 > ? That's right! Thanks! > Also, did you report this clang issue to squid bugzilla? Of course! http://bugs.squid-cache.org/show_bug.cgi?id=4242 > Instead of >> BROKEN= Squid with eCAP enabled can't be compiled by clang > you could say >> USE_GCC=yes > ? Yes, but I think a lot of people would say it's not worth it. But I can be wrong.
I thought it is better to build with gcc rather than break it, but this is your call. I know nothing about this option :-)
(In reply to yuri from comment #6) Hmm, looks like I can set it right there, instead of BROKEN. I'll test it. Thanks a lot!
(In reply to timp87 from comment #7) I realized that it works if libecap is built by gcc too.
If this is C++ you are there, you can't mix gcc and clang. Then it's better to have BANNED.
Sorry, BROKEN
(In reply to yuri from comment #9) Or I can make a patch for www/libecap with the same condition and USE_GCC=yes
If other ports will also use it, this is going to start the string of dependency problems. Better not spread gcc-compiled C++ ports. This in itself is a very nasty problem, such dependencies.
(In reply to yuri from comment #12) Yes, I know. But it seems like squid is the only port which uses www/libecap.
Created attachment 156662 [details] patch
Patch is ready to deploy. We will see how soon squid's developers fix clang compilation problem. If someone complains about BROKEN on FreeBSD >= 10 I will make a patch with USE_GCC=yes for squid and libecap.
Created attachment 156684 [details] patch DragonFlyBSD can use our ports tree, so add ${OPSYS} == FreeBSD condition to ECAP option.
Hmm, this version of squid has some problems with HTTPS stuff. I got such problems in my production. So I think this patch shouldn't go to the ports tree. I'll highlight more info later.
Created attachment 157243 [details] squid-3.5.5 patch Patch to update www/squid to latest 3.5.5 version. I'm running it in production and have no problems. We'll see.
Created attachment 157246 [details] poudriere log
(In reply to timp87 from comment #18) No problems since then. I think it can go to the ports tree.
Committed. Thanks!
A commit references this bug: Author: flo Date: Sun Jun 7 21:03:26 UTC 2015 New revision: 388783 URL: https://svnweb.freebsd.org/changeset/ports/388783 Log: - update to 3.5.5 - fix GASSAPI_NONE handling; - unbreak eCAP option, but only for FreeBSD < 10, no luck with clang. PR: 200070 Submitted by: <timp87@gmail.com> (maintainer) Changes: head/www/squid/Makefile head/www/squid/distinfo head/www/squid/files/patch-configure_GSSAPI_NONE