Bug 200203 - [exp-run] with libgcov (and libgomp) removed from base (if no GCC)
Summary: [exp-run] with libgcov (and libgomp) removed from base (if no GCC)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-14 17:35 UTC by Ed Maste
Modified: 2015-05-18 16:34 UTC (History)
1 user (show)

See Also:

Attachments
Build libgcov only along with base GCC (1.02 KB, patch)
2015-05-14 18:54 UTC, Ed Maste 		no flags Details | Diff
patch v2 (libgcov only), now that libgomp removal is committed in r282973 (1.16 KB, patch)
2015-05-15 14:25 UTC, Ed Maste 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2015-05-14 17:35:22 UTC 
Further to PR 199979 base libgcov is not useful without base GCC -- Clang doesn't use it, and ports GCC will include its own. This patch removes libgcov and libgomp if base GCC is not being built. It includes the libgomp part because I'm still waiting on PR 200192 to fix the one failure with libgomp removed.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2015-05-14 18:44:31 UTC 
I think you forgot to include the patch?
Comment 2 Ed Maste freebsd_committer freebsd_triage 2015-05-14 18:54:12 UTC 
Created attachment 156783 [details]
Build libgcov only along with base GCC
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2015-05-14 20:09:26 UTC 
Take for exp-run
Comment 4 Ed Maste freebsd_committer freebsd_triage 2015-05-15 14:25:30 UTC 
Created attachment 156800 [details]
patch v2 (libgcov only), now that libgomp removal is committed in r282973
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-05-18 15:03:07 UTC 
A commit references this bug:

Author: emaste
Date: Mon May 18 15:02:36 UTC 2015
New revision: 283060
URL: https://svnweb.freebsd.org/changeset/base/283060

Log:
  Build libgcov only if we're building base system GCC

  Clang uses compiler-rt for the code coverage runtime, and ports GCC
  provides its own libgcov.

  PR:		200203 (exp-run)
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/gnu/lib/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc