Bug 200244 - [patch] mail/sendmail : fails stage checks and has some problems
Summary: [patch] mail/sendmail : fails stage checks and has some problems
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-05-16 16:09 UTC by John Marino
Modified: 2015-05-16 18:57 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback-


Attachments
Full sendmail diff (4.78 KB, patch)
2015-05-16 16:09 UTC, John Marino
no flags Details | Diff
poudriere log as it looks today with stage checks (87.94 KB, text/plain)
2015-05-16 16:09 UTC, John Marino
no flags Details
Poudriere log after applying full diff (79.46 KB, text/plain)
2015-05-16 16:10 UTC, John Marino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2015-05-16 16:09:01 UTC
Created attachment 156828 [details]
Full sendmail diff

The mail/sendmail port doesn't come close to passing stage-qa checks (log attached).

The attached patch fixes several issues:
1) properly stages the port
2) uses USERS/GROUPS mechanism instead of home-grown one
3) removes all the obsolete @dirrm from pkg-plist
4) Strips executables / libraries (part of stage check)
5) stops rebuilding submit.cf
6) fixes milter pkg-plist
7) simplifies pkg-plist

Note that because the smmsp user has a home directory of /var/spool/clientmqueue, @dir can't be used.  The @dir and USERS mechanism are clashing.

Will attach:
1) patch to fix port
2) log of poudriere build as it is now
3) log of poudriere build as it will be after patch 

Note that I tested it on FreeBSD 8.4/i386, FreeBSD 9/amd64 and FreeBSD 10/amd64.  Right now I don't have a means to test FreeBSD 11.
Comment 1 John Marino freebsd_committer freebsd_triage 2015-05-16 16:09:55 UTC
Created attachment 156829 [details]
poudriere log as it looks today with stage checks
Comment 2 John Marino freebsd_committer freebsd_triage 2015-05-16 16:10:34 UTC
Created attachment 156830 [details]
Poudriere log after applying full diff
Comment 3 commit-hook freebsd_committer freebsd_triage 2015-05-16 18:46:40 UTC
A commit references this bug:

Author: dinoex
Date: Sat May 16 18:45:45 UTC 2015
New revision: 386569
URL: https://svnweb.freebsd.org/changeset/ports/386569

Log:
  - use USERS/GROUPS
  - removes obsolete @dirrm
  - support STRIP_CMD
  - stops rebuilding submit.cf
  PR:		200244
  Submitted by:	John Marino

Changes:
  head/mail/sendmail/Makefile
  head/mail/sendmail/files/patch-Makefile.m4
  head/mail/sendmail/files/pkg-milter
  head/mail/sendmail/pkg-plist