dports issue reported: https://github.com/DragonFlyBSD/DPorts/issues/153
There are 3 missing dependencies for this port.
USE_PHP+= mysql mysqli openssl session
should be changed to
USE_PHP+= mysql mysqli openssl session hash ctype zlib
Do you concur?
Yes. It does appear that these additional PHP modules would benefit. I'm okay with this patch. I don't see a submitted patch so I'll submit one (I believe there may be a newer version of FrontAccounting as well so I'll update that, too).
okay. I don't need a patch (I can just commit it directly) but if you are going to submit a new version I can also wait for that.
Yep. Looks like version 2.3.24 is available. Building in Poudriere now. Should have a version (and PHP module) patch for you shortly. Thanks!
Created attachment 156958 [details]
Version and PHP module update DIFF.
Port update DIFF.
Attached the port update DIFF and the Poudriere build log can be found at http://clarkson.purplehat.org:8080/data/freebsd_10-1x64-HEAD/latest-per-pkg/frontaccounting-2.3.24.log
the post-install target is bogus, I'm going to remove it.
the install commands cannot be masked (in other words, you can't have "@" in front of the command).
Also compound commands need to be wrapped in parentheses.
I'm going to modernize the options, these are the old style.
there is something weird with mysql.
it's supposedly optional, but USE_MYSQL is set in every case. The value only differs between "yes" and "server"
Maybe the option means "include server" but it's certainly not obvious what the real intent is.
it appears that the NLS option explicitly listed is a mistake. I don't see any action taken as a result of having it. I'm going to remove it.
I guess it was added to try to fix portlint warning about gettext. I'll see about implementing the NLS function first. If it doesn't work, then I'll remove it.
I also had to explicitly add the "DOCS" option to make it work.
Since this is a "NO_BUILD" port, it passes build tests no matter what so I can only assume what I've done work. I guess it really needs runtime checks for !NLS, !MYSQL_SERVER, etc. (the opposite of default options).
yes, I changed "MYSQL" option to "MYSQL_SERVER" option since mysql client is installed unconditionally.
I've made lots of changes to the proposed patch so you'll want to review after I commit this.
oh dear, the pkg-plist is filled full of @dir commands and those are probably bogus. It looks like whoever processed PR 194255 missed that.
A commit references this bug:
Date: Thu May 21 10:08:47 UTC 2015
New revision: 386921
finance/frontaccounting: Upgrade version 2.3.22 => 2.3.24
The version update was done because the port had to address missing PHP
modules anyway. Why here:
* Add the missing hash, ctype, zlib modules
* leverage new options framework to simply options handling
* implement NLS option (was listed, but not implemented)
* explicitly list DOCS option (implemented but unselectable)
* Rename MYSQL option to MYSQL_SERVER because MySQL client is
installed unconditionally so the option name was misleading
* Unsuppress install commands
* Wrap compound commands in parentheses for multijob support
* Wrap to 80 columns
* Remove bogus post-install cat pkgmessage target
* Remove 120 bogus @dir lines introduced in 
PR: 194255 
Reported by: marino
Initial fix: maintainer (ek - purplehat.org)
rest of fixes: marino
hmm, it looks like xmj is the one that actually added those @dir lines (rather than missed them). That was wrong.
Anyway, this is finally done as far as I am concerned.