Bug 200265 - finance/frontaccounting : missing 3 dependencies
Summary: finance/frontaccounting : missing 3 dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-17 13:51 UTC by John Marino
Modified: 2015-05-21 10:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ek)


Attachments
Version and PHP module update DIFF. (8.95 KB, patch)
2015-05-19 18:08 UTC, ek
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer 2015-05-17 13:51:46 UTC
dports issue reported: https://github.com/DragonFlyBSD/DPorts/issues/153

There are 3 missing dependencies for this port.


line:
USE_PHP+=       mysql mysqli openssl session
should be changed to
USE_PHP+=       mysql mysqli openssl session hash ctype zlib


Do you concur?
Comment 1 ek 2015-05-19 15:40:07 UTC
Yes. It does appear that these additional PHP modules would benefit. I'm okay with this patch. I don't see a submitted patch so I'll submit one (I believe there may be a newer version of FrontAccounting as well so I'll update that, too).
Comment 2 John Marino freebsd_committer 2015-05-19 15:42:03 UTC
okay.  I don't need a patch (I can just commit it directly) but if you are going to submit a new version I can also wait for that.
Comment 3 ek 2015-05-19 16:30:34 UTC
Yep. Looks like version 2.3.24 is available. Building in Poudriere now. Should have a version (and PHP module) patch for you shortly. Thanks!
Comment 4 ek 2015-05-19 18:08:43 UTC
Created attachment 156958 [details]
Version and PHP module update DIFF.

Port update DIFF.
Comment 5 ek 2015-05-19 18:09:26 UTC
Attached the port update DIFF and the Poudriere build log can be found at http://clarkson.purplehat.org:8080/data/freebsd_10-1x64-HEAD/latest-per-pkg/frontaccounting-2.3.24.log
Comment 6 John Marino freebsd_committer 2015-05-21 09:10:39 UTC
the post-install target is bogus, I'm going to remove it.
Comment 7 John Marino freebsd_committer 2015-05-21 09:12:07 UTC
the install commands cannot be masked (in other words, you can't have "@" in front of the command).

Also compound commands need to be wrapped in parentheses.
Comment 8 John Marino freebsd_committer 2015-05-21 09:13:21 UTC
I'm going to modernize the options, these are the old style.
Comment 9 John Marino freebsd_committer 2015-05-21 09:18:42 UTC
there is something weird with mysql.

it's supposedly optional, but USE_MYSQL is set in every case.  The value only differs between "yes" and "server"

Maybe the option means "include server" but it's certainly not obvious what the real intent is.
Comment 10 John Marino freebsd_committer 2015-05-21 09:30:10 UTC
it appears that the NLS option explicitly listed is a mistake.  I don't see any action taken as a result of having it.  I'm going to remove it.
Comment 11 John Marino freebsd_committer 2015-05-21 09:33:56 UTC
I guess it was added to try to fix portlint warning about gettext.  I'll see about implementing the NLS function first.  If it doesn't work, then I'll remove it.
Comment 12 John Marino freebsd_committer 2015-05-21 09:53:27 UTC
I also had to explicitly add the "DOCS" option to make it work.

Since this is a "NO_BUILD" port, it passes build tests no matter what so I can only assume what I've done work.  I guess it really needs runtime checks for !NLS, !MYSQL_SERVER, etc. (the opposite of default options).

yes, I changed "MYSQL" option to "MYSQL_SERVER" option since mysql client is installed unconditionally.

I've made lots of changes to the proposed patch so you'll want to review after I commit this.
Comment 13 John Marino freebsd_committer 2015-05-21 10:01:20 UTC
oh dear, the pkg-plist is filled full of @dir commands and those are probably bogus.  It looks like whoever processed PR 194255 missed that.
Comment 14 commit-hook freebsd_committer 2015-05-21 10:09:08 UTC
A commit references this bug:

Author: marino
Date: Thu May 21 10:08:47 UTC 2015
New revision: 386921
URL: https://svnweb.freebsd.org/changeset/ports/386921

Log:
  finance/frontaccounting: Upgrade version 2.3.22 => 2.3.24

  The version update was done because the port had to address missing PHP
  modules anyway.  Why here:

   * Add the missing hash, ctype, zlib modules
   * leverage new options framework to simply options handling
   * implement NLS option (was listed, but not implemented)
   * explicitly list DOCS option (implemented but unselectable)
   * Rename MYSQL option to MYSQL_SERVER because MySQL client is
     installed unconditionally so the option name was misleading
   * Unsuppress install commands
   * Wrap compound commands in parentheses for multijob support
   * Wrap to 80 columns
   * Remove bogus post-install cat pkgmessage target
   * Remove 120 bogus @dir lines introduced in [2]

  PR:		200265
  PR:		194255 [2]
  Reported by:	marino
  Initial fix:	maintainer (ek - purplehat.org)
  rest of fixes:	marino

Changes:
  head/finance/frontaccounting/Makefile
  head/finance/frontaccounting/distinfo
  head/finance/frontaccounting/pkg-plist
Comment 15 John Marino freebsd_committer 2015-05-21 10:12:24 UTC
hmm, it looks like xmj is the one that actually added those @dir lines (rather than missed them).  That was wrong.

Anyway, this is finally done as far as I am concerned.