Bug 200422 - archivers/liblz4: r129 breaks stdout pipelines.
Summary: archivers/liblz4: r129 breaks stdout pipelines.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-24 02:31 UTC by eborisch+FreeBSD
Modified: 2015-05-24 18:05 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eborisch+FreeBSD 2015-05-24 02:31:32 UTC
r129 of liblz4 enabled sparse file support by default; this breaks [1] lz4c decompression when used in a pipeline. For example,  <some compressed lz4 stream> | lz4c -d | <some other tool> isn't working now, but worked in r128.

I would suggest either reverting back to r128 for now, or applying the changes made to the current dev branch [2] which gracefully recovers rather than errors out. 

[1] https://github.com/Cyan4973/lz4/issues/110
[2] https://github.com/Cyan4973/lz4/commit/58b5aadb1fc5d937e81c8f33e0e8290f2097c6bb
Comment 1 commit-hook freebsd_committer 2015-05-24 18:01:33 UTC
A commit references this bug:

Author: riggs
Date: Sun May 24 18:01:05 UTC 2015
New revision: 387288
URL: https://svnweb.freebsd.org/changeset/ports/387288

Log:
  Fix decompression in a pipeline: import fix from dev branch in
  https://github.com/Cyan4973/lz4/commit/58b5aadb1fc5d937e81c8f33e0e8290f2097c6bb

  PR:		200422
  Submitted by:	eborisch+FreeBSD@gmail.com
  Approved by:	adamw (maintainer, implicit)

Changes:
  head/archivers/liblz4/Makefile
  head/archivers/liblz4/files/
  head/archivers/liblz4/files/patch-programs_Makefile
  head/archivers/liblz4/files/patch-programs_lz4cli.c
  head/archivers/liblz4/files/patch-programs_lz4io.c
Comment 2 Thomas Zander freebsd_committer 2015-05-24 18:05:55 UTC
Tested with the example command line from
https://github.com/Cyan4973/lz4/issues/110
on 10.1 and 9.3.