Created attachment 157237 [details]
patch to fix audio/soundconverter
Well just went to install this, and found things weren't
well with this port. So decided I'd fix it...
This port is *really* out of date; current version: 2.1.5!
However, this pr only covers the current version in the ports
tree - 1.5.4. After these changes get committed, I'll cobble
up, and test the current version, and file a new pr. :)
MASTER_SITES, and WWW.
pet portlint; NLS vs gettext
Please find patch (svn diff), and requisite QA LOG, attached.
Created attachment 157238 [details]
QA LOG for audio/soundconverter
I'm setting the MASTER_SITES as shown:
MASTER_SITES= BERLIOS \
According to `make fetch-urlall-list` that is generating valid Sourceforge links to download the file from and the working links have the correct SHA of the file.
QA builds kicked off now just to sanity check nothing has changed. I'll sanity check everything tomorrow after the builds finish overnight and I get sleep.
(In reply to Jason Unovitch from comment #2)
> I'm setting the MASTER_SITES as shown:
> MASTER_SITES= BERLIOS \
> According to `make fetch-urlall-list` that is generating valid Sourceforge
> links to download the file from and the working links have the correct SHA
> of the file.
> QA builds kicked off now just to sanity check nothing has changed. I'll
> sanity check everything tomorrow after the builds finish overnight and I get
> Thanks Chris.
Sounds good, Jason.
A commit references this bug:
Date: Sat Oct 3 00:59:58 UTC 2015
New revision: 398457
audio/soundconverter: pass on maintainership and clean up port
- Pass maintainer from ports@ to submitter
- Add maintainer mirror to MASTER_SITES
- Add NO_ARCH
- Sort USES (portlint)
- Remove unconditional gettext USES and add NLS knob (portlint)
- Update WWW link and update pkg-descr based on upstream verbiage
Submitted by: Chris Hutchinson <firstname.lastname@example.org> (with changes)
(In reply to Chris Hutchinson from comment #3)
This patch had the following QA issue without NLS.
pkg-static: Unable to access file /wrkdirs/root/soundconverter/work/stage/usr/local/share/locale/zh_CN/LC_MESSAGES/soundconverter.mo: No such file or directory
Chris, take a look at the committed changes as this adds the OPTIONS_SUB and %%NLS%% for items that aren't installed without NLS. The words of wisdom here are to consider the third order effects past what portlint or the tool is saying.