Created attachment 157505 [details] fix for breakage caused by commit 1682366 mod_perl-2.0.9-rc2 fails to compile on freebsd-10.1 with apache22 installed due to mod_perl svn commit 1682366, unless perl is built with ITHREADS. This was fixed in the main distribution a couple of commits later, and there's a patch for it here: https://github.com/apache/mod_perl/commit/f1126696da1216e2acee1285698f5aacbae3d9e4
Created attachment 157506 [details] Broken plist for 2.0.9-rc2
pkg-plist is also broken in mod_perl2-2.0.9-rc2. See the second patch to fix this problem
Hi Nick, patch one is OK, but in my tests on 10.1 with perl5.20 I don't see issues with pkg-plist. Can you provide more details about your - perl version plus make showconfig -C lang/perl5.nn - OS release
Hi Olli, I had a look at the distribution and these files are autogenerated using the xs/maps/modperl_types.map file, but they're only autogenerated if PERL_HAS_ITHREADS has been defined in mod_perl2. This is defined if $Config{useithreads} is present in the perl configuration. So if someone builds a single-threaded perl installation, then the ModPerl::{Interpreter,InterpPool,TiPool,TiPoolConfig} modules won't be built and the pkg-plist will throw up an error. The port will need to test for $Config{useithreads} and then create conditional pkg-plist entries. The attached complete patch for this problem should fix this - it works on my single-threaded installation (perl 5.20 / freebsd-10.1-amd64 / apache22).
Created attachment 157524 [details] complete patch for mod_perl2 ithread detection v01
Hi Nick, Thanks for the patches, anyway can you give a hint how you build your perl5 so I can verify in a test build?
from +COMPACT_MANIFEST: "options":{"DEBUG":"off","GDBM":"off","MULTIPLICITY":"off","PERL_64BITINT":"on","PTHREAD":"on","SITECUSTOMIZE":"off","USE_PERL":"on","THREADS":"off","PERL_MALLOC":"off"}
A commit references this bug: Author: ohauer Date: Mon Jun 8 21:53:23 UTC 2015 New revision: 388886 URL: https://svnweb.freebsd.org/changeset/ports/388886 Log: - add patch from upstream trunk - mark broken with perl5.22.x - fix pkg-plist if build against apache22 and perl with THREADS=off - Empty commit with correct PR number PR: 200697 Submitted by: nick(_at_)foobar.org Changes: head/www/mod_perl2/Makefile
Patches committed in modified version, else pkg-plist is not correct for apache24. I have another report from a user, will keep the PR open until I have a positive feedback from that user.
Builds and runs fine for me now (apache22-2.2.29_5, perl5-5.18.4_14). Thanks!