Bug 200709 - [patch] www/p5-RPC-ExtDirect : updating port from upstream version 3.02 to 3.21
Summary: [patch] www/p5-RPC-ExtDirect : updating port from upstream version 3.02 to 3.21
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks: 200652
  Show dependency tree / graph
 
Reported: 2015-06-08 06:41 UTC by Martin Waschbüsch
Modified: 2015-10-10 11:30 UTC (History)
1 user (show)

See Also:

Attachments
Catch up with Upstream (1.45 KB, patch)
2015-06-08 06:41 UTC, Martin Waschbüsch 		no flags Details | Diff
Updated patch (2.75 KB, patch)
2015-10-09 13:31 UTC, Martin Waschbüsch 		no flags Details | Diff
Output of 'portlint -AC' (144 bytes, text/plain)
2015-10-09 13:36 UTC, Martin Waschbüsch 		no flags Details
Output of 'make test' (14.17 KB, text/plain)
2015-10-09 13:36 UTC, Martin Waschbüsch 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2015-06-08 06:41:48 UTC 
Created attachment 157532 [details]
Catch up with Upstream

Updating port p5-RPC-ExtDirect from upstream version 3.02 to 3.21
Comment 1 Frederic Culot freebsd_committer freebsd_triage 2015-06-09 07:49:49 UTC 
Assign to maintainer.
Comment 2 Martin Waschbüsch 2015-10-09 13:31:45 UTC 
Created attachment 161844 [details]
Updated patch

updated the patch to ensure pkg-plist is correct.
Comment 3 Martin Waschbüsch 2015-10-09 13:36:12 UTC 
Created attachment 161845 [details]
Output of 'portlint -AC'
Comment 4 Martin Waschbüsch 2015-10-09 13:36:42 UTC 
Created attachment 161846 [details]
Output of 'make test'
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-09 20:08:47 UTC 
It's really strange, but a

make check-plist

causes this error and I do not understand where this comes from.

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%SITE_ARCH%%/auto/RPC/ExtDirect/.packlist
Error: Orphaned: %%PERL5_MAN3%%/RPC::ExtDirect::Migration.3.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PERL5_MAN3%%/RPC::ExtDirect::Migration.3.gz/usr/local/%%SITE_ARCH%%/auto/RPC/ExtDirect/.packlist
===> Error: Plist issues found.
*** Error code 1
Comment 6 Martin Waschbüsch 2015-10-10 06:29:34 UTC 
Hi Kurt,

One thing caught my eye:

If you look at the patch you can see that your error output suggests that there is a line break missing:
%%PERL5_MAN3%%/RPC::ExtDirect::Migration.3.gz/usr/local/%%SITE_ARCH%%/auto/RPC/ExtDirect/.packlist

should really be

%%PERL5_MAN3%%/RPC::ExtDirect::Migration.3.gz
/usr/local/%%SITE_ARCH%%/auto/RPC/ExtDirect/.packlist

and there would not be any error?

Are you sure the patch applied correctly?

Martin
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-10 07:08:58 UTC 
Yes, pkg-plist looks correct. That's why I'm surprised.

But: Apparently, there was a newline missing at the end of pkg-plist (!)

The second fix was: There was a .packlist entry in the pkg-plist. This
is not needed as it will be automatically added.

It builds fine now, I'm now testing it in poudriere.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-10 11:27:47 UTC 
Testbuilds are fine.
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-10-10 11:30:16 UTC 
A commit references this bug:

Author: pi
Date: Sat Oct 10 11:29:26 UTC 2015
New revision: 398989
URL: https://svnweb.freebsd.org/changeset/ports/398989

Log:
  www/p5-RPC-ExtDirect: 3.02 -> 3.21

  Changes:
  http://cpansearch.perl.org/src/TOKAREV/RPC-ExtDirect-3.21/Changes

  PR:		200709
  Submitted by:	Martin Waschbuesch <martin@waschbuesch.de>
  Approved by:	tj (maintainer timeout)

Changes:
  head/www/p5-RPC-ExtDirect/Makefile
  head/www/p5-RPC-ExtDirect/distinfo
  head/www/p5-RPC-ExtDirect/pkg-plist
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-10 11:30:41 UTC 
Committed, thanks.