Bug 200881 - crunchgen changes in r284382 broken with gcc tinderboxes
Summary: crunchgen changes in r284382 broken with gcc tinderboxes
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Adrian Chadd
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-15 18:37 UTC by Enji Cooper
Modified: 2015-12-13 06:44 UTC (History)
2 users (show)

See Also:
ngie: mfc-stable10?
ngie: mfc-stable9?
ngie: mfc-stable8-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2015-06-15 18:37:32 UTC 
From https://jenkins.freebsd.org/job/FreeBSD_HEAD_sparc64/736/console :

/builds/FreeBSD_HEAD_sparc64/obj/sparc64.sparc64/builds/FreeBSD_HEAD_sparc64/rescue/rescue//builds/FreeBSD_HEAD_sparc64/bin/cat/cat.o
/builds/FreeBSD_HEAD_sparc64/obj/sparc64.sparc64/builds/FreeBSD_HEAD_sparc64/tmp/usr/bin/ld: --relax and -r may not be used together
*** [cat.lo] Error code 1
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2015-06-15 19:35:25 UTC 
contrib/gcc/config/sparc/freebsd.h:
#define LINK_SPEC "%(link_arch)  \
  %{!mno-relax:%{!r:-relax}}   ......

This means -relax is passed to the linker unless -mno-relax or -r appears on the compiler command line.  I guess -Wl,-r in crunchgen code has to be changed back to -r.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-06-15 19:49:26 UTC 
A commit references this bug:

Author: tijl
Date: Mon Jun 15 19:48:29 UTC 2015
New revision: 284422
URL: https://svnweb.freebsd.org/changeset/base/284422

Log:
  Change -Wl,-r back to -r so gcc doesn't pass --relax to the linker on some
  architectures.

  PR:		200881

Changes:
  head/usr.sbin/crunch/crunchgen/crunchgen.c
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2015-06-16 07:10:56 UTC 
MFC is for adrian to decide.
Comment 4 Enji Cooper freebsd_committer freebsd_triage 2015-11-09 09:58:01 UTC 
Adrian: please close this bug if you don't plan on MFCing your changes to crunchgen and bsd.crunchgen.mk .
Comment 5 Enji Cooper freebsd_committer freebsd_triage 2015-12-13 06:44:54 UTC 
Closing bug due to lack of feedback.