Bug 200972 - [exp-run] [patch] Rename __weak to __weak_symbol
Summary: [exp-run] [patch] Rename __weak to __weak_symbol
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Hans Petter Selasky
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-19 14:37 UTC by Hans Petter Selasky
Modified: 2015-06-26 21:35 UTC (History)
2 users (show)

See Also:


Attachments
Kernel header file patch (1008 bytes, patch)
2015-06-19 14:37 UTC, Hans Petter Selasky
no flags Details | Diff
Kernel header file patch (1.03 KB, patch)
2015-06-21 13:22 UTC, Hans Petter Selasky
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer freebsd_triage 2015-06-19 14:37:35 UTC
Created attachment 157884 [details]
Kernel header file patch

Rename __weak macro to __weak_symbol to avoid a language conflict with
objective-C.

Suggested by:	theraven@
MFC after:	1 week
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2015-06-21 10:41:37 UTC
Please provide a patch relative to the src tree,  not the kernel tree
Comment 2 Hans Petter Selasky freebsd_committer freebsd_triage 2015-06-21 13:22:35 UTC
Created attachment 157926 [details]
Kernel header file patch
Comment 3 Hans Petter Selasky freebsd_committer freebsd_triage 2015-06-21 13:22:55 UTC
(In reply to Antoine Brodin from comment #1)
Done.
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2015-06-22 13:14:27 UTC
Take for exp-run
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2015-06-23 18:32:37 UTC
Exp-run results:

http://package18.nyi.freebsd.org/jail.html?mastername=headamd64PR200972-default

0 new failure
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-23 22:41:20 UTC
A commit references this bug:

Author: hselasky
Date: Tue Jun 23 22:40:23 UTC 2015
New revision: 284743
URL: https://svnweb.freebsd.org/changeset/base/284743

Log:
  Rename __weak to __weak_symbol to avoid language conflict with objective-C.

  PR:		200972 (exp-run)
  Suggested by:	theraven@
  MFC after:	3 days

Changes:
  head/sys/sys/cdefs.h
  head/sys/sys/linker_set.h
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-06-26 21:35:55 UTC
A commit references this bug:

Author: hselasky
Date: Fri Jun 26 21:35:37 UTC 2015
New revision: 284880
URL: https://svnweb.freebsd.org/changeset/base/284880

Log:
  MFC r284743:
  Rename __weak to __weak_symbol to avoid language conflict with objective-C.

  PR:		200972 (exp-run)
  Suggested by:	theraven@

Changes:
_U  stable/10/
  stable/10/sys/sys/cdefs.h
  stable/10/sys/sys/linker_set.h