Bug 200986 - sys/dev/isci/scil/scif_sas_controller.c:531: bad if ?
Summary: sys/dev/isci/scil/scif_sas_controller.c:531: bad if ?
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 10.1-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-20 08:35 UTC by David Binderman
Modified: 2019-02-07 13:50 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-06-20 08:35:20 UTC 
sys/dev/isci/scil/scif_sas_controller.c:531]: (warning) Logical conjunction always evaluates to false: EXPR < 1 && EXPR > 32.

 if (scif_parms->sas.max_ncq_depth < 1 && scif_parms->sas.max_ncq_depth > 32)

Maybe

 if (scif_parms->sas.max_ncq_depth < 1 || scif_parms->sas.max_ncq_depth > 32)
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2019-02-07 13:50:05 UTC 
Fixed in base r315205.