Bug 201256 - [patch] x11/libXpm: fix build with devel/gettext-runtime installed
Summary: [patch] x11/libXpm: fix build with devel/gettext-runtime installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-01 18:02 UTC by Andriy Voskoboinyk
Modified: 2015-07-01 20:33 UTC (History)
3 users (show)

See Also:


Attachments
Makefile.diff (348 bytes, patch)
2015-07-01 18:02 UTC, Andriy Voskoboinyk
no flags Details | Diff
portlint.log (186 bytes, text/plain)
2015-07-01 18:02 UTC, Andriy Voskoboinyk
no flags Details
poudriere-10.1-amd64.log (41.61 KB, text/plain)
2015-07-01 18:04 UTC, Andriy Voskoboinyk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2015-07-01 18:02:04 UTC
Created attachment 158229 [details]
Makefile.diff

By default, configure autodetects the gettext library - and if it exists, then it will be added as cxpm/sxpm dependency. As a result: 1) build may fail if devel/gettext-tools port is not installed and 2) the port has implicit dependency to devel/gettext-runtime in case of success.

Fix: disable gettext autodetection (i.e., set ac_cv_search_gettext=no in CONFIGURE_ENV)

Also, add INSTALL_TARGET=install-strip
Comment 1 Andriy Voskoboinyk freebsd_committer 2015-07-01 18:02:57 UTC
Created attachment 158230 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer 2015-07-01 18:04:31 UTC
Created attachment 158231 [details]
poudriere-10.1-amd64.log
Comment 3 commit-hook freebsd_committer 2015-07-01 20:30:01 UTC
A commit references this bug:

Author: johans
Date: Wed Jul  1 20:29:41 UTC 2015
New revision: 391122
URL: https://svnweb.freebsd.org/changeset/ports/391122

Log:
  - Make implicit dependency on gettext explicit (and enable by default)
    also disable autodetection when not desired
  - Strip installed library
  - Bump portrevision

  PR:		201256
  Submitted by:	Andriy Voskoboinyk

Changes:
  head/x11/libXpm/Makefile
Comment 4 Johan van Selst freebsd_committer 2015-07-01 20:33:38 UTC
Well spotted. In fact, this wasn't detected where libintl was not in the default link path. I have now added an NLS option for those who desire gettext() support and enabled it by default.