Bug 201895 - archivers/pigz: respect CC/CFLAGS/LDFLAGS and convert to system libzopfli
Summary: archivers/pigz: respect CC/CFLAGS/LDFLAGS and convert to system libzopfli
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: feature, patch
Depends on: 201894
Blocks:
  Show dependency tree / graph
 
Reported: 2015-07-26 18:11 UTC by Jan Beich
Modified: 2015-08-16 03:07 UTC (History)
0 users

See Also:
delphij: maintainer-feedback+

Attachments
v1 (1.67 KB, patch)
2015-07-26 18:11 UTC, Jan Beich 		no flags Details | Diff
84amd64 poudriere bulk -t log (12.44 KB, text/plain)
2015-07-26 18:21 UTC, Jan Beich 		no flags Details
93i386 poudriere bulk -t log (12.19 KB, text/plain)
2015-07-26 18:22 UTC, Jan Beich 		no flags Details
101i386 poudriere bulk -t log (12.57 KB, text/plain)
2015-07-26 18:22 UTC, Jan Beich 		no flags Details
head_i386 poudriere bulk -t log (12.68 KB, text/plain)
2015-07-26 18:22 UTC, Jan Beich 		no flags Details
102amd64 poudriere bulk -t log (12.41 KB, text/plain)
2015-08-01 07:25 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:11:53 UTC 
Created attachment 159255 [details]
v1

It appears files/patch-Makefile fails to remove CC/CFLAGS while post-patch fails to append -lm. Instead of fixing them override variables via MAKE_ARGS which is more robust.

libzopfli will be available in archivers/zopfli once bug 201894 lands. Adopt and remove now superfluous -lm.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:15:00 UTC 
Example of not respected CFLAGS which should have -fstack-protector and -fno-strict-aliasing nowadays.

  $ make
  ...
  cc -O3 -Wall -Wextra   -c -o pigz.o pigz.c

http://beefy5.nyi.freebsd.org/data/101i386-default/392703/logs/pigz-2.3.3.log
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:21:57 UTC 
Created attachment 159262 [details]
84amd64 poudriere bulk -t log
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:22:00 UTC 
Created attachment 159263 [details]
93i386 poudriere bulk -t log
Comment 4 Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:22:03 UTC 
Created attachment 159264 [details]
101i386 poudriere bulk -t log
Comment 5 Jan Beich freebsd_committer freebsd_triage 2015-07-26 18:22:06 UTC 
Created attachment 159265 [details]
head_i386 poudriere bulk -t log
Comment 6 Xin LI freebsd_committer freebsd_triage 2015-07-27 05:43:35 UTC 
Patch looks good to me, please feel free to commit once 201894 landed.
Comment 7 Jan Beich freebsd_committer freebsd_triage 2015-08-01 07:25:50 UTC 
Created attachment 159427 [details]
102amd64 poudriere bulk -t log
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-08-16 03:03:49 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Aug 16 03:03:40 UTC 2015
New revision: 394384
URL: https://svnweb.freebsd.org/changeset/ports/394384

Log:
  archivers/pigz: convert to system libzopfli and respect CC/CFLAGS/LDFLAGS

  PR:		201895
  Approved by:	delphij (maintainer)

Changes:
  head/archivers/pigz/Makefile
  head/archivers/pigz/files/
Comment 9 Jan Beich freebsd_committer freebsd_triage 2015-08-16 03:07:09 UTC 
Thanks. Committed.
Comment 10 Jan Beich freebsd_committer freebsd_triage 2015-08-16 03:07:20 UTC 
Thanks. Committed.