Created attachment 159708 [details]
Patch to update Makefile, distinfo, and patch files.
files/patch-urlview.c will be to be removed.
Created attachment 159709 [details]
USE_GITHUB pass 2. Forgot url_handler.sh
Forgot url_handler.sh in patch-sample.urlview
Upstream fixes and auto* fixes
Also, adds support for a new QUITONLAUNCH configuration option.
Created attachment 159716 [details]
less craft from git-format-patch used git-diff instead since, I'm guessing, we don't care about the per commit messages.
What is the benefit of github version? As I see it's unmaintained too :(
I'd like to get QUITONLAUNCH in the port version.
Not updated for the past 2 years (compared to 15 for mutt's ftp contrib dir) but it's the location for any development if/when it happens.
Oh, QUITONLAUNCH... it's a good feature :)
I'll check tomorrow.
Don't use PORTREVISION when the version of the port changes. Change PORTVERSION to something like 0.9.2015.08.11, or the date of the last commit, but don't use PORTREVISION to for that. PORTREVISION is to use when the software does not change but the port changes. (Say, you add an option, change a default, strip a file.)
Created attachment 159768 [details]
per comment #7 Don't use PORTREVISION when the version of the port changes.
Created attachment 159794 [details]
Removed POREREVISION since it's reset on version change. Added alignment in Makefile.
Please, don't reindent the whole makefile, the previous patch was almost perfect (PORTREVISION should have gone completly) :-)
Created attachment 159805 [details]
I think PORTVERSION should be 20131020 - without 0.9.
And I don't see any reason why don't you delete patch-sample.urlview.
I believe keeping the 0.9 would be a good idea only because it's 0.9 currently however it's a non-tagged development version. It's possible that a new tag (0.10) could be created on the git repo and then in turn you could remove the GIT_TAGNAME ex:
Removing that patch might be fine I don't know the history behind the reason for the change. Could be old/historic to reference 'netscape' (I believe this would be from ~97-2000 time frame) and since post-patch removes all references to url_handler.sh with 'firefox'
Might be a good patch for upstream (if it will ever get applied).
Commit message for that change:
Author: crees <crees@FreeBSD.org>
Date: Mon Aug 15 15:19:39 2011 +0000
Handle alternative browsers correctly.
Submitted by: Stefan Thurner <firstname.lastname@example.org> Test Rat <email@example.com>
Approved by: Anton Shterenlikht <firstname.lastname@example.org> (maintainer)
Also forgot to mention that other OS/distros (not that it's valid) keep the version number along with a commit/development-id ex Fedora:
I don't think it will 0.10, it seems it's an abandonware.
About PORTVERSION: "For example, if a snapshot release is made on the date 20000917, and the previous version of the software was version 1.2, do not use 20000917 for PORTVERSION. The correct way is a PORTVERSION of 1.2.20000917" (Porter's Handbook). So your version will be the right way :)
I think if you modify your patch to remove patch-sample.urlview and attach poudriere log, will acceptable.
(About other distros: I think FreeBSD isn't Linux. FreeBSD has a policy (and handbook) about ports and should follow it.)
The PORTREVISION of 0.9.date is the way to go.
(In reply to Mathieu Arnold from comment #16)
Created attachment 159840 [details]
Use 0.9.20131021 per porter's handbook
Created attachment 159843 [details]
poudriere 10amd64 logs
poudriere 10amd64 logs
Created attachment 159844 [details]
poudriere 9amd64 logs
Comment on attachment 159840 [details]
Created attachment 159851 [details]
poudriere 10i386 logs
Created attachment 159852 [details]
poudriere 9i386 logs
I think it's okay.
Anything missing that's blocking this from being committed?
A commit references this bug:
Date: Thu Sep 10 02:51:32 UTC 2015
New revision: 396549
- Update to 0.9.20131021
- Switch to USE_GITHUB
- Add WWW
Submitted by: email@example.com
Approved by: firstname.lastname@example.org(maintainer)