Bug 202301 - usr/src/usr.bin/sort/coll.c:1090: bad if test ?
Summary: usr/src/usr.bin/sort/coll.c:1090: bad if test ?
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-13 17:20 UTC by David Binderman
Modified: 2017-05-10 20:31 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2015-08-13 17:20:21 UTC 
[usr/src/usr.bin/sort/coll.c:1090] -> [usr/src/usr.bin/sort/coll.c:1090]: (style) Same expression on both sides of '>'.

  if (d2 > d2)

Maybe

  if (d1 > d2)
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-28 17:13:39 UTC 
A commit references this bug:

Author: marius
Date: Wed Dec 28 17:13:04 UTC 2016
New revision: 310712
URL: https://svnweb.freebsd.org/changeset/base/310712

Log:
  - Use correct offsets into the keys set array. As the elements of this
    zero-length array are dynamically sized at run-time based on the use
    of hints, compilers can't be expected to figure out these offsets on
    their own. [1]
  - Fix incorrect comparison in cmp_nans(). [2]

  PR:		204571 [1], 202301 [2]
  Submitted by:	David Binderman [2]
  MFC after:	3 days

Changes:
  head/usr.bin/sort/coll.c
  head/usr.bin/sort/coll.h
  head/usr.bin/sort/radixsort.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-05-10 20:29:11 UTC 
A commit references this bug:

Author: marius
Date: Wed May 10 20:29:02 UTC 2017
New revision: 318152
URL: https://svnweb.freebsd.org/changeset/base/318152

Log:
  MFC: r310712

  - Use correct offsets into the keys set array. As the elements of this
    zero-length array are dynamically sized at run-time based on the use
    of hints, compilers can't be expected to figure out these offsets on
    their own. [1]
  - Fix incorrect comparison in cmp_nans(). [2]

  PR:		204571 [1], 202301 [2]
  Submitted by:	David Binderman [2]

Changes:
_U  stable/10/
  stable/10/usr.bin/sort/coll.c
  stable/10/usr.bin/sort/coll.h
  stable/10/usr.bin/sort/radixsort.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-05-10 20:30:15 UTC 
A commit references this bug:

Author: marius
Date: Wed May 10 20:29:33 UTC 2017
New revision: 318153
URL: https://svnweb.freebsd.org/changeset/base/318153

Log:
  MFC: r310712

  - Use correct offsets into the keys set array. As the elements of this
    zero-length array are dynamically sized at run-time based on the use
    of hints, compilers can't be expected to figure out these offsets on
    their own. [1]
  - Fix incorrect comparison in cmp_nans(). [2]

  PR:		204571 [1], 202301 [2]
  Submitted by:	David Binderman [2]

Changes:
_U  stable/11/
  stable/11/usr.bin/sort/coll.c
  stable/11/usr.bin/sort/coll.h
  stable/11/usr.bin/sort/radixsort.c