Bug 202327 - [patch] Add better disk support to net-mgmt/collectd5
Summary: [patch] Add better disk support to net-mgmt/collectd5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brad Davis
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-14 16:32 UTC by Brad Davis
Modified: 2015-08-16 08:22 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
patch (20.25 KB, patch)
2015-08-14 16:33 UTC, Brad Davis 		no flags Details | Diff
Merged python support from bug #201773 (9.15 KB, patch)
2015-08-14 18:34 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
Merged support for bug #201773 - corrected (9.22 KB, patch)
2015-08-14 18:51 UTC, Krzysztof 		ports: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2015-08-14 16:32:29 UTC 
A few people, myself included have worked to improve collectd's disk metrics on FreeBSD.  It adds disk I/O operations and latency metrics.  The dependency on libstatgrab has been removed for disk statistics.  We just got the improvements pushed in upstream, see GitHub: https://github.com/collectd/collectd/pull/1188.

I would like to have them available to everyone now since collectd releases are not very often.  This patch has been running well for a week on my systems.
Comment 1 Brad Davis freebsd_committer freebsd_triage 2015-08-14 16:33:04 UTC 
Created attachment 159863 [details]
patch
Comment 2 Krzysztof 2015-08-14 17:59:05 UTC 
OK, Thanks a lot for your work. I aproove.
Comment 3 Krzysztof 2015-08-14 18:04:27 UTC 
Please wait with commit of this patch - I wold like to merge it with #201773 - correct support python with DEBUG. I will try to merge these two patched and add cumulative one. Thanks a lot.
Comment 4 Krzysztof 2015-08-14 18:34:50 UTC 
Created attachment 159870 [details]
Merged python support from bug #201773
Comment 5 Brad Davis freebsd_committer freebsd_triage 2015-08-14 18:51:06 UTC 
Close, your cumulative patch misses the changes to src/disk.c, but I will fix it up. Thank you!
Comment 6 Krzysztof 2015-08-14 18:51:09 UTC 
Created attachment 159872 [details]
Merged support for bug #201773 - corrected
Comment 7 Krzysztof 2015-08-14 18:54:07 UTC 
I'm not able to make your patch obsolete - could you do it yourself? Thanks.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-08-14 19:31:07 UTC 
A commit references this bug:

Author: brd
Date: Fri Aug 14 19:30:13 UTC 2015
New revision: 394253
URL: https://svnweb.freebsd.org/changeset/ports/394253

Log:
  Add native disk metrics thanks to delphij, Ruben Kerkhof
  <ruben@rubenkerkhof.com>, and myself. [1]

  Fix Python option when building with debug enabled python [2]

  PR:		202327 [1]
  PR:		201773 [2]
  Submitted by:	brd [1]
  Submitted by:	Suraj Ravichandran <suraj@ixsystems.com> [2]
  Approved by:	Krzysztof <ports@bsdserwis.com> (maintainer), bdrewery (mentor)

Changes:
  head/net-mgmt/collectd5/Makefile
  head/net-mgmt/collectd5/files/patch-configure.ac
  head/net-mgmt/collectd5/files/patch-src__Makefile.am
  head/net-mgmt/collectd5/pkg-plist
Comment 9 Brad Davis freebsd_committer freebsd_triage 2015-08-14 19:32:39 UTC 
Committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-08-16 08:22:11 UTC 
A commit references this bug:

Author: brd
Date: Sun Aug 16 08:21:21 UTC 2015
New revision: 394392
URL: https://svnweb.freebsd.org/changeset/ports/394392

Log:
  Opps, forgot to actually add the patch file to actually give us the new disk support!

  PR:		202327
  Approved by:	bdrewery (mentor)

Changes:
  head/net-mgmt/collectd5/files/patch-src_disk.c