Bug 202403 - [MAINTAINER] multimedia/mpv: fix OPTIONS
Summary: [MAINTAINER] multimedia/mpv: fix OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-18 01:35 UTC by Carlos J Puga Medina
Modified: 2015-08-18 06:37 UTC (History)
1 user (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2015-08-18 01:35 UTC, Carlos J Puga Medina
no flags Details | Diff
Patch (2.11 KB, patch)
2015-08-18 03:10 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-08-18 01:35:41 UTC
Created attachment 159968 [details]
Patch

- Use ASS, DVDREAD and DVDNAV options helpers.
- Bump PORTREVISION.
Comment 1 Jan Beich freebsd_committer 2015-08-18 02:59:48 UTC
Comment on attachment 159968 [details]
Patch

>-OPTIONS_DEFINE=		BS2B DOCS ENCA LADSPA LCMS2 LIBGUESS LUAJIT ZSH
>+OPTIONS_DEFINE=		ASS BS2B DOCS ENCA LADSPA LCMS2 \
>+			LIBGUESS LUAJIT ZSH

ASS, DVDREAD, DVDNAV should be in OPTIONS_DEFAULT as well to keep features for packages users intact. Besides, mpv relies on libass even for OSD unlike mplayer.
Comment 2 Carlos J Puga Medina 2015-08-18 03:10:47 UTC
Created attachment 159971 [details]
Patch

Oops, It was an oversight.
Comment 3 commit-hook freebsd_committer 2015-08-18 03:59:24 UTC
A commit references this bug:

Author: jbeich
Date: Tue Aug 18 03:58:37 UTC 2015
New revision: 394552
URL: https://svnweb.freebsd.org/changeset/ports/394552

Log:
  multimedia/mpv: expose ASS, DVDREAD, DVDNAV options

  PR:		202403
  Submitted by:	Carlos J Puga Medina <cpm@fbsd.es> (maintainer)
  MFH:		2015Q3

Changes:
  head/multimedia/mpv/Makefile
Comment 4 Jan Beich freebsd_committer 2015-08-18 04:01:21 UTC
Thanks. Committed.

I've also mentioned OSD in ASS_DESC to avoid surprises: --disable-libass implies --disable-libass-osd. OSD is important for a player without GUI. ;)
Comment 5 commit-hook freebsd_committer 2015-08-18 06:37:35 UTC
A commit references this bug:

Author: jbeich
Date: Tue Aug 18 06:37:04 UTC 2015
New revision: 394560
URL: https://svnweb.freebsd.org/changeset/ports/394560

Log:
  MFH: r394552

  multimedia/mpv: expose ASS, DVDREAD, DVDNAV options

  PR:		202403
  Submitted by:	Carlos J Puga Medina <cpm@fbsd.es> (maintainer)
  Approved by:	ports-secteam (delphij)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/multimedia/mpv/Makefile