Created attachment 159993 [details] Add a regexp fix to utils.go There's a regexp bug in the hostname validator. We hit this in the freebsd.org cluster where it doesn't allow '-' in hostname via the address setting calls. eg: the cli doesn't feel that something like "ftp-master.freebsd.org" is allowed. I've got this patch submitted upstream, but the github repo for syncthing-cli tracks the master branch of syncthing but we're using the v0.11 branch. syncthing-cli no longer compiles with the v0.11 branch due to internal reorganizations. So, I've added the fix here rather than bumping the syncthing-cli port. We are using this as a local patch in the cluster poudriere builds.
FWIW, this was committed upstream: https://github.com/syncthing/syncthing-cli/commit/ee077f02d8bed430658f5a33710cf0cf5bb3f546 The only problem is we can't use the upstream version any more as it tracks the internal changes in syncthing mainline, rather than v0.11. If we could get this fix committed until 0.12 (or whatever its called) is out, it'd be appreciated.
A commit references this bug: Author: swills Date: Sun Aug 30 17:17:29 UTC 2015 New revision: 395629 URL: https://svnweb.freebsd.org/changeset/ports/395629 Log: net/syncthing-cli: patch for hostname parser While here, fix build by using Go 1.4 until upstream supports Go 1.5 PR: 202425 Submitted by: peter Changes: head/net/syncthing-cli/Makefile head/net/syncthing-cli/files/ head/net/syncthing-cli/files/patch-utils.go
Naturally, revert this when v0.12 comes out.