Bug 202593 - [PATCH]: www/nginx-devel add 3rd party tarantool module
Summary: [PATCH]: www/nginx-devel add 3rd party tarantool module
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sergey A. Osokin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-23 13:59 UTC by Veniamin Gvozdikov
Modified: 2015-08-27 17:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (osa)

Attachments
Patch with tarantool support (3.73 KB, patch)
2015-08-23 13:59 UTC, Veniamin Gvozdikov 		no flags Details | Diff
Patch withouth bump portrevision (2.54 KB, patch)
2015-08-24 06:53 UTC, Veniamin Gvozdikov 		no flags Details | Diff
With patch (3.57 KB, patch)
2015-08-24 08:46 UTC, Veniamin Gvozdikov 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-08-23 13:59:13 UTC 
Created attachment 160247 [details]
Patch with tarantool support

Tarantool NginX upstream module

- Benefit from nginx features and tarantool features over HTTP(S).
- Call tarantool methods via JSON RPC.
- Load Balancing with elastic configuration.
- Backup and fault tolerance.
- Low overhead.
Comment 1 Sergey A. Osokin freebsd_committer freebsd_triage 2015-08-24 01:54:36 UTC 
Could you please don't bump PORTREVISION, this is needless cause new third-party module won't be enabled by default, so, please provide new version of patch.
Comment 2 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-08-24 06:53:37 UTC 
Created attachment 160290 [details]
Patch withouth bump portrevision

Done.
Comment 3 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-08-24 08:46:26 UTC 
Created attachment 160297 [details]
With patch

Missed add extra patch for last patch without bump portrevision
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2015-08-24 11:58:15 UTC 
Looks better now.

Does it working for www/nginx-devel port, 1.9.4 now?  If so, could you please add the same change for www/nginx-devel port into the patch, we will try to kill two birds with one stone.
Comment 5 Veniamin Gvozdikov freebsd_committer freebsd_triage 2015-08-24 12:21:29 UTC 
(In reply to Sergey A. Osokin from comment #4)

I have tried patch for both 1.8.X and 1.9.X (nginx/nginx-devel). It works fine.
Comment 6 Sergey A. Osokin freebsd_committer freebsd_triage 2015-08-27 00:27:15 UTC 
Veniadmin,

go ahead and commit your changes to www/nginx and www/nginx-devel in one commit.

Thanks for report.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-08-27 17:37:25 UTC 
A commit references this bug:

Author: vg
Date: Thu Aug 27 17:36:33 UTC 2015
New revision: 395441
URL: https://svnweb.freebsd.org/changeset/ports/395441

Log:
  Added 3rd party tarantool upstream module:

  Tarantool NginX upstream module

  - Benefit from nginx features and tarantool features over HTTP(S).
  - Call tarantool methods via JSON RPC.
  - Load Balancing with elastic configuration.
  - Backup and fault tolerance.
  - Low overhead.

  PR:		ports/202593
  Approved by:	osa

Changes:
  head/www/nginx/Makefile
  head/www/nginx/distinfo
  head/www/nginx/files/extra-patch-ngx_http_tarantool-config
  head/www/nginx-devel/Makefile
  head/www/nginx-devel/distinfo
  head/www/nginx-devel/files/extra-patch-ngx_http_tarantool-config