Bug 202599 - multimedia/libass: convert ASM to option helpers
Summary: multimedia/libass: convert ASM to option helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2015-08-23 18:25 UTC by Jan Beich
Modified: 2015-08-26 06:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
v0 (1.21 KB, patch)
2015-08-23 18:25 UTC, Jan Beich 		no flags Details | Diff
QA: poudriere testport -j 93i386 (33.75 KB, text/plain)
2015-08-23 18:27 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-08-23 18:25:48 UTC 
Created attachment 160259 [details]
v0

This should get rid of double inclusion of bsd.port.mk. I'm not sure whether to bump PORTREVISION as ASM is now gone for non-x86 archs where it wasn't supported.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2015-08-23 18:27:01 UTC 
Created attachment 160260 [details]
QA: poudriere testport -j 93i386
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2015-08-26 05:32:53 UTC 
*** Bug 202587 has been marked as a duplicate of this bug. ***
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2015-08-26 05:41:38 UTC 
Handling bug 202587 as part of this one.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-08-26 06:22:36 UTC 
A commit references this bug:

Author: riggs
Date: Wed Aug 26 06:22:27 UTC 2015
New revision: 395348
URL: https://svnweb.freebsd.org/changeset/ports/395348

Log:
  Convert ASM to option helpers, make ASM arch-dependent

  - Provide ASM option only on supported archs (i386, amd64)
  - i386: ASM is no longer default OPTION (fixes bug 252587)
  - Bump PORTREVISION

  PR:		202599
  Submitted by:	jbeich
  Reviewed by:	riggs

Changes:
  head/multimedia/libass/Makefile
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2015-08-26 06:25:12 UTC 
(In reply to commit-hook from comment #4)

Typo:

- i386: ASM is no longer default OPTION (fixes bug 252587)

should be:

- i386: ASM is no longer default OPTION (fixes bug 202587)