Bug 202608 - bsd.options.mk: support custom option helpers
Summary: bsd.options.mk: support custom option helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks: 202609
  Show dependency treegraph
 
Reported: 2015-08-24 02:30 UTC by Jan Beich
Modified: 2015-08-28 12:47 UTC (History)
1 user (show)

See Also:


Attachments
v0 (671 bytes, patch)
2015-08-24 02:30 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2015-08-24 02:30:36 UTC
Created attachment 160281 [details]
v0

Complex ports may want to toggle an arbitrary variable via FOO + FOO_OFF states. After some time popular non-intrinsic variables can be moved into the main file. See examples in blocked bugs.
Comment 1 Baptiste Daroussin freebsd_committer 2015-08-24 05:57:22 UTC
If _OPTIONS_FLAGS becomes public it should not start with a _

Maybe also rename to something more accurate (but sorry I do not have good imagination here OPTIONS_HELPERS_TAGS?

I would probably prefer going to something like:
_OPTIONS_FLAGS= ${OPTIONS_HELPERS_TAGS} ...

without the +

I general I do like the principle of adding more flexibility here.
What do others thinks?
Comment 2 Mathieu Arnold freebsd_committer 2015-08-24 09:00:54 UTC
I've thought about doing it this way, but variables starting with _ are private, and should not be used outside of where they're defined.

I'm working on https://reviews.freebsd.org/D3410 right now, which is more where we want to go.
Comment 3 Jan Beich freebsd_committer 2015-08-28 12:47:58 UTC
ports r395468 works fine for me.