Bug 202652 - Introduce a version support in USES=ninja
Summary: Introduce a version support in USES=ninja
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-25 11:57 UTC by Grzegorz Blach
Modified: 2015-08-29 14:41 UTC (History)
1 user (show)

See Also:
gblach: exp-run?

Attachments
ninja.diff (9.69 KB, patch)
2015-08-25 11:57 UTC, Grzegorz Blach 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Blach freebsd_committer freebsd_triage 2015-08-25 11:57:47 UTC 
Created attachment 160346 [details]
ninja.diff

Changes in attached patch:
- Add version support in USES=ninja
- Move devel/ninja16 to devel/ninja
- Add devel/ninja15 as subport
- Make some minor improves in devel/ninja
- Change USES=ninja to USES=ninja:15 in graphics/darktable

Now I need a full exp-run to see if there are more ports that need USES=ninja:15 to build correctly. And also to verify that I don't broke anything.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2015-08-26 12:38:01 UTC 
I disagree with this change.
In my opinion darktable should be fixed instead (there are already warnings with ninja 1.5)
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2015-08-26 12:38:42 UTC 
I disagree with this change.
In my opinion darktable should be fixed instead (there are already warnings with ninja 1.5)
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2015-08-26 12:42:03 UTC 
Maybe just remove USES=ninja from darktable, it should get back into using plain make instead and should just work given darktable is a cmake based project
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2015-08-26 15:04:51 UTC 
https://reviews.freebsd.org/D3247 <= fixed with this
Comment 5 Grzegorz Blach freebsd_committer freebsd_triage 2015-08-26 20:53:27 UTC 
It's great that updated darktable supports ninja 1.6, but I still need a exp-run. Maybe there are more ports which can't be build using ninja 1.6.
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2015-08-28 17:26:04 UTC 
There was already an "exp-run" 10 days ago:

http://package20.nyi.freebsd.org/build.html?mastername=93amd64-default-baseline&build=394432

The only new failure back then was graphics/darktable
Comment 7 Grzegorz Blach freebsd_committer freebsd_triage 2015-08-29 14:41:03 UTC 
Thanks