Bug 202911 - graphics/py-cairo: remove unecessary & faulty bits from Makefile
Summary: graphics/py-cairo: remove unecessary & faulty bits from Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-05 17:07 UTC by John Hein
Modified: 2016-07-31 18:56 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
patch - remove some wrong & unecessary settings (488 bytes, patch)
2015-09-05 17:07 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2015-09-05 17:07:05 UTC
Created attachment 160746 [details]
patch - remove some wrong & unecessary settings

The PYTHON passed in CONFIGURE_ENV is wrong (evaluates to /usr/local/bin//usr/local/bin/python2.7, for example) and not needed anyway.

Also CPPFLAGS & LDFLAGS aren't needed.  The configure step knows how to find everything it needs and sets build flags appropriately.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-07-25 23:12:09 UTC
A commit references this bug:

Author: jbeich
Date: Mon Jul 25 23:12:05 UTC 2016
New revision: 419081
URL: https://svnweb.freebsd.org/changeset/ports/419081

Log:
  graphics/py-cairo: clean up

  - PYTHON_CMD already contains LOCALBASE
  - PYTHON is already passed to CONFIGURE_ENV
  - PREFIX and *FLAGS are redundant
  - Respect PREFIX != LOCALBASE while stripping [1]

  PR:		202911
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>
  Approved by:	maintainer timeout (11 months)
  Approved by:	portmgr blanket [1]
  MFH:		2016Q3

Changes:
  head/graphics/py-cairo/Makefile
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-07-25 23:13:22 UTC
Thanks. Landed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-07-31 18:56:18 UTC
A commit references this bug:

Author: jbeich
Date: Sun Jul 31 18:56:04 UTC 2016
New revision: 419405
URL: https://svnweb.freebsd.org/changeset/ports/419405

Log:
  MFH: r419081

  graphics/py-cairo: clean up

  - PYTHON_CMD already contains LOCALBASE
  - PYTHON is already passed to CONFIGURE_ENV
  - PREFIX and *FLAGS are redundant
  - Respect PREFIX != LOCALBASE while stripping [1]

  PR:		202911
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>
  Approved by:	maintainer timeout (11 months)
  Approved by:	portmgr blanket [1]
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/graphics/py-cairo/Makefile