Bug 203048 - sysutils/nut: modernize plist
Summary: sysutils/nut: modernize plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-11 19:29 UTC by Dmitry Marakasov
Modified: 2015-11-24 15:13 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Patch (1.67 KB, patch)
2015-09-11 19:29 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-11 19:29:33 UTC 
Created attachment 160935 [details]
Patch

- Modernize directory handling in plist
- Switch to options helpers
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-16 16:09:23 UTC 
(also adds missing files to plist)
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-09-17 06:16:05 UTC 
A commit references this bug:

Author: cy
Date: Thu Sep 17 06:15:42 UTC 2015
New revision: 397100
URL: https://svnweb.freebsd.org/changeset/ports/397100

Log:
  Install netxml-ups, update pkg-plist.

  PR:		203048
  Submitted by:	amdmi3

Changes:
  head/sysutils/nut/Makefile
  head/sysutils/nut/pkg-plist
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2015-09-17 06:17:11 UTC 
Committed. Thanks.
Comment 4 Alexander Zagrebin 2015-09-17 20:29:13 UTC 
It seems that netxml-ups is available only if the NEON option is active.
So pkg-plist's lines
libexec/nut/netxml-ups
man/man8/netxml-ups.8.gz
has to be replaced with
%%NUT_NEON%%libexec/nut/netxml-ups
%%NUT_NEON%%man/man8/netxml-ups.8.gz
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-18 11:11:06 UTC 
Sorry, that was undertested. Actually, there are more problems with some options:

AVAHI: does not build (cannot find avahi libs)
BASH: plist broken (does not actually install completions)
IPMIPSU: does not build
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-09-18 11:14:38 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Sep 18 11:14:23 UTC 2015
New revision: 397231
URL: https://svnweb.freebsd.org/changeset/ports/397231

Log:
  - Fix plist

  PR:		203048

Changes:
  head/sysutils/nut/pkg-plist
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2015-09-18 14:37:51 UTC 
(In reply to Dmitry Marakasov from comment #5)
Not able to reproduce locally. Build logs, please.
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-18 20:21:12 UTC 
(In reply to Cy Schubert from comment #7)
> (In reply to Dmitry Marakasov from comment #5)
> Not able to reproduce locally. Build logs, please.

https://people.freebsd.org/~amdmi3/nut-logs/
Comment 9 Cy Schubert freebsd_committer freebsd_triage 2015-09-20 04:02:34 UTC 
Thanks for the log. Fixed.
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-22 23:18:10 UTC 
BADH and IPMISU still do not build.
Comment 11 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-24 15:13:23 UTC 
BASH option was fixed, and I