Bug 203077 - [NEW PORT] devel/sonarqube: Platform for continuous inspection of code quality
Summary: [NEW PORT] devel/sonarqube: Platform for continuous inspection of code quality
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-13 16:37 UTC by Dušan Vejnovič
Modified: 2016-06-25 22:52 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments
shar file for devel/sonarqube (184.90 KB, text/plain)
2015-09-13 16:37 UTC, Dušan Vejnovič
no flags Details
poudriere build log for devel/sonarqube (20.16 KB, text/x-log)
2015-09-13 16:37 UTC, Dušan Vejnovič
no flags Details
new groups (304 bytes, patch)
2015-09-13 16:38 UTC, Dušan Vejnovič
no flags Details | Diff
new users (957 bytes, patch)
2015-09-13 16:38 UTC, Dušan Vejnovič
no flags Details | Diff
shar file for devel/sonarqube (172.56 KB, text/plain)
2015-12-25 18:45 UTC, Dušan Vejnovič
rakuco: maintainer-approval+
Details
poudriere build log for devel/sonarqube (22.06 KB, text/x-log)
2015-12-25 18:45 UTC, Dušan Vejnovič
no flags Details
shar file for devel/sonarqube (171.14 KB, text/plain)
2016-04-10 07:27 UTC, Dušan Vejnovič
no flags Details
shar file for devel/sonarcube (style revision) (171.02 KB, text/plain)
2016-05-12 00:33 UTC, Jason Unovitch
no flags Details
shar file for devel/sonarqube (188.49 KB, text/plain)
2016-05-14 17:16 UTC, Dušan Vejnovič
no flags Details
shar file for devel/sonarqube (188.49 KB, text/plain)
2016-05-14 18:40 UTC, Dušan Vejnovič
no flags Details
shar file for devel/sonarqube (rev 3) (188.29 KB, text/plain)
2016-06-06 01:27 UTC, Jason Unovitch
no flags Details
shar file for devel/sonarqube (187.33 KB, text/plain)
2016-06-11 09:18 UTC, Dušan Vejnovič
freebsd: maintainer-approval+
Details
poudriere build log for devel/sonarqube (amd64) (17.59 KB, text/x-log)
2016-06-11 09:19 UTC, Dušan Vejnovič
no flags Details
poudriere build log for devel/sonarqube (i386) (17.63 KB, text/x-log)
2016-06-11 09:20 UTC, Dušan Vejnovič
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dušan Vejnovič 2015-09-13 16:37:37 UTC
Created attachment 160995 [details]
shar file for devel/sonarqube

The SonarQube platform is an open source quality management platform, dedicated
to continuously analyzing and measuring the technical quality of source code,
from project portfolio down to the method level.

Features:
- Supports languages: Java, C/C++, Objective-C, C#, PHP, Flex, Groovy,
  JavaScript, Python, PL/SQL, COBOL, etc.
- Can also be used in Android development.
- Offers reports on duplicated code, coding standards, unit tests, code
  coverage, complex code, potential bugs, comments and design and architecture.
- Records metrics history and provides evolution graphs ("time machine") and
  differential views.
- Provides fully automated analyses: integrates with Maven, Ant, Gradle and 
  continuous integration tools (Atlassian Bamboo, Jenkins, Hudson, etc.).
- Integrates with the Eclipse development environment.
- Integrates with external tools: JIRA, Mantis, LDAP, Fortify, etc.
- Is expandable with the use of plugins.
- Implements the SQALE methodology to compute technical debt.

WWW: http://www.sonarqube.org
Comment 1 Dušan Vejnovič 2015-09-13 16:37:58 UTC
Created attachment 160996 [details]
poudriere build log for devel/sonarqube
Comment 2 Dušan Vejnovič 2015-09-13 16:38:10 UTC
Created attachment 160997 [details]
new groups
Comment 3 Dušan Vejnovič 2015-09-13 16:38:23 UTC
Created attachment 160998 [details]
new users
Comment 4 Dušan Vejnovič 2015-12-25 18:45:22 UTC
Created attachment 164636 [details]
shar file for devel/sonarqube

- removed sonarqube user and group
- added www user and group
- removed iconv from USES
- added iconv dependency to LIB_DEPENDS
- optimized re-inplace command in post-patch section
- upgraded to 5.2
Comment 5 Dušan Vejnovič 2015-12-25 18:45:50 UTC
Created attachment 164637 [details]
poudriere build log for devel/sonarqube
Comment 6 Dušan Vejnovič 2016-04-10 07:27:11 UTC
Created attachment 169135 [details]
shar file for devel/sonarqube

devel/sonarqube: 5.2 -> 5.4

- Remove ${PORTSDIR}/ from DEPENDS line
- Replace download address
- Changelog at https://jira.sonarsource.com/jira/secure/ReleaseNote.jspa?projectId=10930&version=12781
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2016-05-12 00:33:15 UTC
Created attachment 170222 [details]
shar file for devel/sonarcube (style revision)

- Fixed excessive tabs in Makefile
- Wrap at 76 chars in pkg-descr
- Reorder Makefile per portlint
- Fix Windows newlines that prevent SVN from adding the patches

There are still some portlint issues:

WARN: /usr/ports/devel/sonarqube/pkg-plist: [6]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: /usr/ports/devel/sonarqube/pkg-plist: [9]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: Makefile: possible use of absolute pathname "/var/log/${PORTNAME}".
WARN: Makefile: no ftp/http mirror in MASTER_SITES for users behind a proxy.
WARN: Makefile: no port directory /usr/ports/devel/wrapper found, even though it is listed in RUN_DEPENDS.
WARN: /usr/ports/devel/sonarqube/files/patch-conf_wrapper.conf: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

I'm not seeing a PR for devel/wrapper nor is this in ports.  What's going on with this RUN_DEPENDS?
Comment 8 Dušan Vejnovič 2016-05-14 17:16:06 UTC
Created attachment 170284 [details]
shar file for devel/sonarqube

- Upgrade to 5.5
- Fixed excessive tabs in Makefile
- Wrap at 76 chars in pkg-descr
- Reorder Makefile per portlint
- Fix Windows newlines that prevent SVN from adding the patches
Comment 9 Dušan Vejnovič 2016-05-14 17:19:29 UTC
(In reply to Dušan Vejnovič from comment #8)

Forgot:
- Remove devel/wrapper from RUN_DEPENDS
- Add sysutils/javaservicewrapper to RUN_DEPENDS
Comment 10 Dušan Vejnovič 2016-05-14 18:40:36 UTC
Created attachment 170287 [details]
shar file for devel/sonarqube

- Fix library path for libwrapper.so in sonarqube's wrapper config
Comment 11 Jason Unovitch freebsd_committer freebsd_triage 2016-06-06 01:27:36 UTC
Created attachment 171079 [details]
shar file for devel/sonarqube (rev 3)

Hi, sorry for the delay here. I made a few more changes but am still seeing QA issues on all 32 bit.

Error: Orphaned: sonarqube/bin/freebsd-%%SQ_ARCH%%/sonar.sh.sample
Error: Orphaned: @dir sonarqube/bin/freebsd-%%SQ_ARCH%%/lib
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: sonarqube/bin/freebsd-x86-64/sonar.sh.sample
Error: Missing: @dir sonarqube/bin/freebsd-x86-64/lib
Error: Missing: @dir sonarqube/bin/freebsd-x86-64

The changes in this shar:
- Fix excessive tabs again (please check your editor settings, you are bound have problems in future submissions when the patches don't apply because your editor is doubling up on tabs)
- Drop CONFLICTS on nonexistent port
- Drop pkg-message from SUB_FILES (nothing to sub)
- Convert to PGSQL option to option helper rather than bsd.port.options.mk include [see 1]

[1] https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

Can you look into the 32 bit QA issue?
Comment 12 Jason Unovitch freebsd_committer freebsd_triage 2016-06-06 01:29:08 UTC
(In reply to Jason Unovitch from comment #11)
Oh, I forgot to mention that it seems strange to remove all the Linux files but include all the Windows and MacOSX files in the plist.  We should probably remove them all for consistency.

The rm's I see that don't have a corresponding Windows/Mac rm:
        @${RM} -drf ${STAGEDIR}${SQ_HOME}/bin/linux-x86-32
        @${RM} -drf ${STAGEDIR}${SQ_HOME}/bin/linux-x86-64
Comment 13 Dušan Vejnovič 2016-06-11 09:18:04 UTC
Created attachment 171297 [details]
shar file for devel/sonarqube

Upgrade to 5.6
Remove CONFLICTS
Remove ARCH variable
Fix build on i386
Comment 14 Dušan Vejnovič 2016-06-11 09:19:16 UTC
Created attachment 171298 [details]
poudriere build log for devel/sonarqube (amd64)
Comment 15 Dušan Vejnovič 2016-06-11 09:20:06 UTC
Created attachment 171299 [details]
poudriere build log for devel/sonarqube (i386)
Comment 16 Dušan Vejnovič 2016-06-11 09:26:39 UTC
(In reply to Dušan Vejnovič from comment #13)
Forgot:
Remove all the Windows and MacOSX files
Comment 17 commit-hook freebsd_committer freebsd_triage 2016-06-25 22:49:33 UTC
A commit references this bug:

Author: junovitch
Date: Sat Jun 25 22:48:42 UTC 2016
New revision: 417498
URL: https://svnweb.freebsd.org/changeset/ports/417498

Log:
  New port: devel/sonarqube

  The SonarQube platform is an open source quality management platform,
  dedicated to continuously analyzing and measuring the technical quality of
  source code, from project portfolio down to the method level.

  Features:
  - Supports languages: Java, C/C++, Objective-C, C#, PHP, Flex, Groovy,
    JavaScript, Python, PL/SQL, COBOL, etc.
  - Can also be used in Android development.
  - Offers reports on duplicated code, coding standards, unit tests, code
    coverage, complex code, potential bugs, comments and design and
    architecture.
  - Records metrics history and provides evolution graphs ("time machine")
    and differential views.
  - Provides fully automated analyses: integrates with Maven, Ant, Gradle and
    continuous integration tools (Atlassian Bamboo, Jenkins, Hudson, etc.).
  - Integrates with the Eclipse development environment.
  - Integrates with external tools: JIRA, Mantis, LDAP, Fortify, etc.
  - Is expandable with the use of plugins.
  - Implements the SQALE methodology to compute technical debt.

  WWW: http://www.sonarqube.org/

  PR:		203077
  Submitted by:	Dusan Vejnovic <freebsd@dussan.org>

Changes:
  head/devel/Makefile
  head/devel/sonarqube/
  head/devel/sonarqube/Makefile
  head/devel/sonarqube/distinfo
  head/devel/sonarqube/files/
  head/devel/sonarqube/files/patch-conf_wrapper.conf
  head/devel/sonarqube/files/pkg-message.in
  head/devel/sonarqube/files/sonarqube.in
  head/devel/sonarqube/pkg-descr
  head/devel/sonarqube/pkg-plist
Comment 18 Jason Unovitch freebsd_committer freebsd_triage 2016-06-25 22:52:22 UTC
Sorry for the delay as I was distracted with other tasks.  The port has been committed.  Please take a look at your editor settings as mentioned earlier as the last .shar file still had additional tab characters and this will likely make future submissions more difficult if the diffs fail to apply.

I didn't address the additional Windows/Mac OSX files being installed.  They likely should be cleaned up on a future update.