Created attachment 161040 [details] Patch Use -isystem for ${LOCALBASE}/include path. - This fixes potential build failures with -Werror because of warnings in third party includes - This enforces correct include directory order, fixing potential problems when an application uses its own includes from system during build instead of ones from WRKDIR This change was approved by bapt, and no requires an exp-run. Differential revision: https://reviews.freebsd.org/D3618
Exp-run results on 9.3 i386: http://package22.nyi.freebsd.org/jail.html?mastername=93i386-default-PR203101 0 new failure Exp-run results on 10.2 amd64: http://package23.nyi.freebsd.org/jail.html?mastername=102amd64-default-PR203101 0 new failure
A commit references this bug: Author: amdmi3 Date: Tue Sep 15 21:24:42 UTC 2015 New revision: 397026 URL: https://svnweb.freebsd.org/changeset/ports/397026 Log: - Use -isystem instead of -I to add ${LOCALBASE}/include to the list of header search paths First, this prevents ports which use strict -Werror settings from build failures in third party headers (real life example is devel/pructl which uses -Werror -Weverything and fails in libedit header on actually harmless padding warning). Second, this prevents ports which install headers from picking up their own headers from LOCALBASE instead of using ones from WRKDIR, which leads to any kind of problems when upgrading via ports. PR: 203101 Approved by: bapt Differential Revision: D3618 Changes: head/Mk/Uses/localbase.mk