Created attachment 161263 [details]
This software is a filter program used with Common UNIX Printing System (CUPS). This can supply the high quality print with Seiko Epson Color Ink Jet Printers.
This product supports only EPSON ESC/P-R printers.
Created attachment 161264 [details]
Created attachment 161265 [details]
Created attachment 161270 [details]
patch for LEGAL
Created attachment 161272 [details]
Thank you for your submission. I reviewed your port skeleton and created a revised one. The following was fixed or modified:
1. Drop GPLv3 from LICENSE. The license terms in the distfile just say GPLv2 or later, so choosing GPLv2 is enough.
2. RESTRICTED is not required since Epson's EULA is not applicable because GPL disallows any further restriction on redistribution of the distfile. The distfile has been copied from the original site to FreeBSD project's public FTP server and MASTER_SITES points it now.
3. Do not use USE_GCC whenever possible. Necessary patches to fix build with Clang (and GCC) are added.
4. Fix configure.ac instead of using CPPFLAGS, LDFLAGS, and CONFIGURE_ARGS. Using result of cups-config is the most reliable way.
Please review this attached version and let me know if there is regression or something you are concerned about. I will commit it after your review.
Thank you for reviewing and creating a revised port skeleton. The revised one can be used immediately.
I added GPLv3 and RESTRICTED because we must press the agree button before downloading and GPLv3 is referred from Epson's Software License Agreement. I think the distfile is not restricted when it is redistributed from another site, too. So I want to rent space of FreeBSD project's public FTP server.
And, thank you for create patches for source files. But, I am concerned about cups-config.
I expect that when cups-client and this ports have different PREFIX, this port's pkg-plist doesn't work correctly. Perhaps, all ports that use pkg-config, cups-config, or *-config have this issue.
A commit references this bug:
Date: Wed Sep 23 16:31:42 UTC 2015
New revision: 397623
Add print/epson-inkjet-printer-escpr, CUPS driver for EPSON inkjet
printers with ESC/P-R control language under GPL. The port name is
the same one as Linux's while it is a bit lengthy.
Submitted by: email@example.com
(In reply to Tatsuki Makino from comment #5)
Thanks for your feedback. Committed it for now.
For PREFIX stuff, it is true that pkg-plist becomes broken when cups-config --datadir returns a different PREFIX. However, the same PREFIX is substantially required to install the filter program to the expected location.
Different PREFIXes which FreeBSD Ports Collection (currently) supports is just for library location, not other binaries or data files. Although it should eventually be improved in some way, I think relying on cups-config is okay at this moment. I will revisit it if it should be modified in the future.