Bug 203489 - [exp-run] bsd.port.mk support for adding using when PKG_ROOTDIR is set
Summary: [exp-run] bsd.port.mk support for adding using when PKG_ROOTDIR is set
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brad Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-01 19:05 UTC by Brad Davis
Modified: 2015-10-29 15:31 UTC (History)
2 users (show)

See Also:
brd: exp-run?

Attachments
patch (3.55 KB, patch)
2015-10-14 14:36 UTC, Brad Davis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Brad Davis freebsd_committer freebsd_triage 2015-10-01 19:15:39 UTC 
I worked on this patch with Bapt to support cross installs when doing Crochet builds. It works for my testing with pkg installing users/groups for isc-dhcpd in crochet for ARM images.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2015-10-03 09:09:17 UTC 
+.if ${OSVERSION} < 1002000

does pw -R work or not on dragonfly?
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2015-10-03 09:16:03 UTC 
No it does not
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2015-10-12 20:35:55 UTC 
(In reply to Baptiste Daroussin from comment #3)
So the patch has to be adjusted for this
(something like .if ${OPSYS} != FreeBSD || ${OSVERSION} < 1002000 )
Comment 5 Brad Davis freebsd_committer freebsd_triage 2015-10-14 14:36:48 UTC 
Created attachment 162041 [details]
patch

Updated patch to support DFly
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2015-10-21 22:46:05 UTC 
Exp-run results on 10.1 i386:
http://pb2.nyi.freebsd.org/jail.html?mastername=101i386-default-PR203489

Exp-run results on 10.2 i386:
http://package18.nyi.freebsd.org/jail.html?mastername=102i386-default-PR203489

No new failures, looks fine.
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-10-22 16:26:26 UTC 
A commit references this bug:

Author: brd
Date: Thu Oct 22 16:25:52 UTC 2015
New revision: 399992
URL: https://svnweb.freebsd.org/changeset/ports/399992

Log:
  Teach the ports framework to handle creating users/groups when
  PKG_ROOTDIR is set.  This will enable help support pkg cross installs.

  PR:		203489
  Reviewed by:	bapt
  Approved by:	portmgr (bapt)
  Approved by:	bdrewery (mentor)

Changes:
  head/Mk/bsd.port.mk
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-10-29 15:31:00 UTC 
A commit references this bug:

Author: brd
Date: Thu Oct 29 15:30:36 UTC 2015
New revision: 400469
URL: https://svnweb.freebsd.org/changeset/ports/400469

Log:
  Fix a bug introduced in r399992, where creating only a user would fail
  due to $PW not being set.  This only occurred when just a user was being
  created without a group.  Solve this by setting $PW outside of the group
  creation and above both the user and group creation parts.

  PR:		203489
  Reviewed by:	bapt
  Approved by:	portmgr (bapt)
  Approved by:	bdrewery (mentor)

Changes:
  head/Mk/bsd.port.mk