Bug 203660 - mail/mimedefang: fix dirs and modernize a bit
Summary: mail/mimedefang: fix dirs and modernize a bit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-09 15:22 UTC by Pavel Timofeev
Modified: 2015-10-27 16:50 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+


Attachments
port patch (11.76 KB, patch)
2015-10-09 15:22 UTC, Pavel Timofeev
koobs: maintainer-approval+
Details | Diff
poudriere log (48.91 KB, text/plain)
2015-10-19 09:59 UTC, Pavel Timofeev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Timofeev 2015-10-09 15:22:19 UTC
Created attachment 161856 [details]
port patch

Hi!
The existing port doesn't set right user for /var/spool/MIMEDefang and /var/spool/MD-Quarantine dirs. Fix it.
As addition, I tried to modernize port a little bit to make portlint happier.
Comment 1 m.tsatsenko 2015-10-10 18:33:50 UTC
Hi!
Thanks for you work.
The patch seems ok, but I am going to update the port to the latest version along with it.
I will submit a modified patch next week.
Comment 2 Pavel Timofeev 2015-10-19 08:56:49 UTC
(In reply to m.tsatsenko from comment #1)
Hi!
Well, I'd prefer you to approve this PR first, but it's up to you.
I think there is no assurance you will have time to work on more massive update. This bug report would make mail/mimedefang work from the box at least.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 09:14:22 UTC
@Tim, can you confirm this passes QA?
Comment 4 Pavel Timofeev 2015-10-19 09:59:52 UTC
Created attachment 162201 [details]
poudriere log

(In reply to Kubilay Kocak from comment #
This is it.
Comment 5 m.tsatsenko 2015-10-19 20:25:30 UTC
Hi!
Sounds reasonable. I will submit another PR for an update.
The patch approved. Thanks!
Comment 6 Pavel Timofeev 2015-10-24 06:37:19 UTC
(In reply to Kubilay Kocak from comment #3)
 Hi! So what's next? I mean what's the plan?
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-24 06:55:47 UTC
@Tim Plan: A nice committer comes along and takes (assigns) the issue to themselves for committing :) That's always the plan. 

TLDR: You've done everything you need to.
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-27 16:09:31 UTC
Testing@work
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-10-27 16:49:36 UTC
A commit references this bug:

Author: pi
Date: Tue Oct 27 16:49:28 UTC 2015
New revision: 400330
URL: https://svnweb.freebsd.org/changeset/ports/400330

Log:
  mail/mimedefang: set correct users for working directories, pet portlint

  PR:		203660
  Submitted by:	Pavel Timofeev <timp87@gmail.com>
  Approved by:	m.tsatsenko@gmail.com (maintainer)

Changes:
  head/mail/mimedefang/Makefile
  head/mail/mimedefang/files/patch-Makefile.in
  head/mail/mimedefang/files/patch-examples__init-script.in
  head/mail/mimedefang/files/patch-mimedefang-filter.5.in
  head/mail/mimedefang/files/patch-mimedefang.pl.in
  head/mail/mimedefang/pkg-install
  head/mail/mimedefang/pkg-plist
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-27 16:50:43 UTC
Test-builds are all fine, committed, thanks!