Bug 203734 - devel/py-sip: Allow concurrent python installations
Summary: devel/py-sip: Allow concurrent python installations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: easy, needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-13 07:28 UTC by Matthieu Volat
Modified: 2015-12-07 04:27 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
Add concurrent to USE_PYTHON (385 bytes, text/plain)
2015-10-13 07:28 UTC, Matthieu Volat 		koobs: maintainer-approval-
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2015-10-13 07:28:19 UTC 
Created attachment 161976 [details]
Add concurrent to USE_PYTHON

Hi,

While I'm trying to figure out to properly install PyQt4 for python 2 and 3, there's devel/py-sip which can be fixed quite easily with simply adding "concurrent" to USE_PYTHON.

Would you consider doing that?

Thanks,
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-03 16:09:30 UTC 
> Would you consider doing that?

Yes, we would :-) This ended up being done in our experimental area51 repositories as part of the work to import PyQt5 into the tree. I expect it to land some time this month.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-03 16:10:54 UTC 
maintaner-feedback- to the patch, though. Just USE_PYTHON=concurrent is not enough, the {DATA,DOCS}DIR lines below also need to be removed. This has been done in area51.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-04 02:38:37 UTC 
Comment on attachment 161976 [details]
Add concurrent to USE_PYTHON

@rakuco, please use maintain-approval to approve/reject individual attachments :)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-04 02:38:48 UTC 
Comment on attachment 161976 [details]
Add concurrent to USE_PYTHON

Whoops.
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-06 21:04:16 UTC 
In the end, it makes more sense to land this separately from the PyQt5 commits. Doing that in a moment...
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-06 21:09:53 UTC 
A commit references this bug:

Author: rakuco
Date: Sun Dec  6 21:09:01 UTC 2015
New revision: 403164
URL: https://svnweb.freebsd.org/changeset/ports/403164

Log:
  py-sip: Allow concurrent Python installations.

  Add USE_PYTHON=concurrent and make the necessary adjustments:
  - Stop setting DATADIR and DOCSDIR, they are taken care of by
    USE_PYTHON=concurrent.
  - Use Python's compileall module instead of py_compile so that Python 3
    byte-code does not contain ${STAGEDIR}.
  - Remove %%DATADIR%% from the plist, which was generated by py_compile.

  PR:		203734

Changes:
  head/devel/py-sip/Makefile
  head/devel/py-sip/pkg-plist
Comment 7 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-06 21:10:44 UTC 
Done, thanks everyone for the contributions!
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-07 04:27:09 UTC 
Assign to committer that resolved