Bug 203747 - java/openjdk8: Respect CC
Summary: java/openjdk8: Respect CC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: freebsd-java (Nobody)
URL:
Keywords: needs-patch, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-13 18:09 UTC by Sean Bruno
Modified: 2015-12-14 23:09 UTC (History)
5 users (show)

See Also:
koobs: maintainer-feedback? (java)


Attachments
patch toolchain.m4 with support for non-default CC (1.79 KB, application/x-m4)
2015-10-13 18:09 UTC, Sean Bruno
no flags Details
patch toolchain.m4 with support for non-default CC (2.43 KB, patch)
2015-11-09 15:40 UTC, Sean Bruno
no flags Details | Diff
An alternate patch to Makefile (910 bytes, patch)
2015-12-09 21:59 UTC, Jung-uk Kim
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2015-10-13 18:09:28 UTC
Created attachment 161992 [details]
patch toolchain.m4 with support for non-default CC

Patch to add non-default CC locations to java build.  Helps me build openjdk8 via poudriere + qemu due to use of non-default CC toolchains.  Submitted by Steve Kiernan from Juniper.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2015-10-13 23:09:03 UTC
To what file should this patch be applied?
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2015-10-14 15:16:43 UTC
(In reply to Mark Linimon from comment #1)
Its a patch file for java/openjdk8/files/ ... not a patch to be applied to java/openjdk8
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 09:33:15 UTC
@Sean, Can you provide the patch against the port please (you can use `make makepatch` for simplicity and correctness if you'd like)

Also, has this passed QA (poudriere), in particular successfully testing switching CC ?
Comment 4 Sean Bruno freebsd_committer freebsd_triage 2015-11-09 15:40:58 UTC
Created attachment 162925 [details]
patch toolchain.m4 with support for non-default CC

Regenerate patch file with svn diff
Comment 5 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-09 21:59:31 UTC
Created attachment 164028 [details]
An alternate patch to Makefile

I think this patch is simpler and easier to maintain.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-14 23:03:20 UTC
A commit references this bug:

Author: jkim
Date: Mon Dec 14 23:02:50 UTC 2015
New revision: 403745
URL: https://svnweb.freebsd.org/changeset/ports/403745

Log:
  Respect CC, CPP and CXX with full paths.

  PR:		203747

Changes:
  head/java/openjdk8/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-12-14 23:06:22 UTC
A commit references this bug:

Author: jkim
Date: Mon Dec 14 23:05:49 UTC 2015
New revision: 403746
URL: https://svnweb.freebsd.org/changeset/ports/403746

Log:
  Respect CC, CPP and CXX with full paths.

  PR:		203747

Changes:
  head/java/openjdk8/Makefile
Comment 8 Jung-uk Kim freebsd_committer freebsd_triage 2015-12-14 23:09:05 UTC
It should be fixed with r403745 and r403746.