Bug 203898 - converters/libiconv: 1.14_9 fails to build
Summary: converters/libiconv: 1.14_9 fails to build
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-20 16:26 UTC by jake.guffey
Modified: 2015-10-21 02:56 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
Output from portmaster -bdg converters/libiconv 2>&1 (35.55 KB, text/plain)
2015-10-20 17:41 UTC, jake.guffey 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jake.guffey 2015-10-20 16:26:01 UTC 
Attempting to build libiconv-1.14_9 (upgrading from 1.14_8) fails on FreeBSD 10.2-RELEASE amd64. This failure occurs consistently on multiple machines.

If any additional information is needed, I would be happy to provide it.

Partial output from "portmaster -bdg libiconv":

/bin/sh ./build-aux/mkinstalldirs /usr/ports/converters/libiconv/work/libiconv-1.14/lib
cannot open ./build-aux/mkinstalldirs: No such file or directory
*** [install-lib] Error code 2

make[3]: stopped in /usr/ports/converters/libiconv/work/libiconv-1.14/libcharset
1 error

make[3]: stopped in /usr/ports/converters/libiconv/work/libiconv-1.14/libcharset
*** [lib/localcharset.h] Error code 2

make[2]: stopped in /usr/ports/converters/libiconv/work/libiconv-1.14
1 error

make[2]: stopped in /usr/ports/converters/libiconv/work/libiconv-1.14
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/converters/libiconv
*** Error code 1

Stop.
make: stopped in /usr/ports/converters/libiconv

===>>> make build failed for converters/libiconv
===>>> Aborting update
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2015-10-20 17:28:46 UTC 
Can you capture the full output and attach it to this bug?
Comment 2 jake.guffey 2015-10-20 17:41:28 UTC 
Created attachment 162255 [details]
Output from portmaster -bdg converters/libiconv 2>&1

Per @tijl's request, full build output from portmaster -bdg converters/libiconv 2>&1 >libiconv_build
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2015-10-20 18:34:52 UTC 
It's doing a parallel build but this port does not support that.  Did you modify the port or anything under /usr/ports/Mk?  Anything special in /etc/make.conf?  Does "env | grep MAKE" print anything?
Comment 4 jake.guffey 2015-10-20 18:42:12 UTC 
(In reply to Tijl Coosemans from comment #3)

> It's doing a parallel build but this port does not support that.
I was unaware that this port doesn't support parallel builds. These servers' job is to build packages as updates appear continually. Is there a way to selectively remove parallelization for individual ports?

> Did you modify the port or anything under /usr/ports/Mk?
Nothing.

> Anything special in /etc/make.conf?
.if !(make(*install) || make(package))
MAKE_ARGS+=-j9
.endif

for parallel builds.

> Does "env | grep MAKE" print anything?
Nothing.

I guess the lesson here for me is to check if a port doesn't support parallel builds before submitting a PR.
Comment 5 Tijl Coosemans freebsd_committer freebsd_triage 2015-10-20 19:26:23 UTC 
(In reply to jake.guffey from comment #4)
> .if !(make(*install) || make(package))
> MAKE_ARGS+=-j9
> .endif

The ports tree already adds -jX wherever it can, with X equal to the output of "sysctl kern.smp.cpus" by default.  You can set a custom value if you want, e.g. the three lines above can be replaced with MAKE_JOBS_NUMBER=9.
Comment 6 jake.guffey 2015-10-20 19:31:02 UTC 
I was unaware of that. Thanks for your help. I'll mark this as closed now that the port has built successfully.