Created attachment 162300 [details] patch Hi, this patch fixes the build problem I'm having and I've updated the version to 1.6.4. I also put -O2 back to CFLAGS, I'm not sure why it was removed (maybe it was unstable)? Also, xombrero built against GTK 3 segfaults on my machine (with or without this fix, and also binary version from pkg repository segfaults). GTK 2 version works fine. BR, Marko
Created attachment 162302 [details] patch-new new patch, forgot some files in last patch.
Since maintainer is not responding, can anyone else take a look at this? BR, Marko
You've given me about a week on this. Unfortunately, I have a day job and other duties as well, so I haven't gotten around to this yet.
@Niclas, always set maintainer-feedback (+) to avoid timeouts (automated, or otherwise) even if you don't action the request/patch itself. @Marko, please obsolete one of the attachments so the issue is clear on which one should be looked at/committer (if approved). Also, if building is currently broken, it should be split up into two commits, so that the build fix can be merged to the quarterly branch without the update.
Building xombrero on a FreeBSD 10.2-RELEASE-p7 amd64 system failed, showing this message: --- xombrero --- cc -fstack-protector -L/usr/local/lib -lwebkitgtk-1.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lpthread -lgdk_pixbuf-2.0 -lpangoft2-1.0 -lpango-1.0 -lfontconfig -lfreetype -ljavascriptcoregtk-1.0 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl -lgnutls -o xombrero *.o -lutil /usr/lib/crt1.o: In function `_start': /usr/local/DEVEL/src/10.2/lib/csu/amd64/crt1.c:(.text+0x16b): undefined reference to `main' cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [xombrero] Error code 1 make[2]: stopped in /usr/local/DEVEL/ports/www/xombrero/work/xombrero-1.6.3/freebsd 1 error make[2]: stopped in /usr/local/DEVEL/ports/www/xombrero/work/xombrero-1.6.3/freebsd ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Using this patch worked for me: comment #1
Created attachment 165704 [details] portlint-xombrero-1.6.4
Created attachment 165705 [details] svn-diff_www_xombrero-1.6.4
Created attachment 165708 [details] poudriere_xombrero-1.6.4
Hi! I'm still working on this. There seems to be a race somewhere in the build, at least with GTK2, as that build fails for me from time to time (when running in poudriere). I will commit the buildfix and update as soon as that is resolved.
A commit references this bug: Author: rm Date: Thu May 5 21:44:54 UTC 2016 New revision: 414668 URL: https://svnweb.freebsd.org/changeset/ports/414668 Log: www/xombrero: unbreak; update to 1.6.4 This patch is cherry-picked from 4 different PRs and one upstream bug report [1] Changes are: - fix build and runtime (based on [1]). I also tried patches and solutions from PR's, but they didn't worked for some reason - update to 1.6.4 - convert to options helpers and add other simplifications to Makefile - sync installed files with Makefile, bundled into distribution - add upstream patch to fix some GTK3 warnings This was tested both at build and runtime with both GTK versions. Also HTML5 video playback was tested - there was a report that it doesn't work. [1] https://github.com/conformal/xombrero/issues/131 PR: 192779 203939 205646 209301 Submitted by: various persons Changes: head/www/xombrero/Makefile head/www/xombrero/distinfo head/www/xombrero/files/patch-freebsd__Makefile head/www/xombrero/files/patch-xombrero.css head/www/xombrero/pkg-descr head/www/xombrero/pkg-plist
For some reason this solution doesn't worked. But similar solution was committed.