Bug 203973 - [PATCH] www/trafficserver: add cacheurl plugin
Summary: [PATCH] www/trafficserver: add cacheurl plugin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-23 08:48 UTC by Terry Chou
Modified: 2015-10-27 13:45 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback+

Attachments
Add cacheurl plugin for www/trafficserver (750 bytes, text/plain)
2015-10-23 08:48 UTC, Terry Chou 		no flags Details
[New] Add cacheurl plugin for www/trafficserver (855 bytes, patch)
2015-10-26 02:43 UTC, Terry Chou 		tequila7211: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Chou 2015-10-23 08:48:25 UTC 
Created attachment 162379 [details]
Add cacheurl plugin for www/trafficserver

Add cacheurl plugin for www/trafficserver

trafficserver support cacheurl with option "--enable-experimental-plugins".

Here a simple patch of the Makefile to purpose the option.
Comment 1 Terry Chou 2015-10-26 02:43:00 UTC 
Created attachment 162453 [details]
[New] Add cacheurl plugin for www/trafficserver
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-26 06:28:10 UTC 
@Terry, could you plesae set the maintainer-approval flag on the patch you wish a committer to use, and set 'obsolete' on the attachment that you dont
Comment 3 Terry Chou 2015-10-26 06:47:37 UTC 
Comment on attachment 162379 [details]
Add cacheurl plugin for www/trafficserver

obsolete
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-26 06:56:41 UTC 
Thank you terry
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2015-10-27 12:46:42 UTC 
Next time, please try to use the canonical way of making a patch[1], and at least, try to not reverse the order of the files while running diff.

1: https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html#svn-diff
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-10-27 13:45:06 UTC 
A commit references this bug:

Author: mat
Date: Tue Oct 27 13:44:23 UTC 2015
New revision: 400239
URL: https://svnweb.freebsd.org/changeset/ports/400239

Log:
  Add a CACHEURL option.

  - not enabling it by default, it does not seem to build on 9
  - convert to options helpers, and use OPTIONS_SINGLE instead of OPTIONS_RADIO.

  PR:		203973
  Submitted by:	maintainer
  Sponsored by:	Absolight

Changes:
  head/www/trafficserver/Makefile
  head/www/trafficserver/pkg-plist